Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .devfile.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
schemaVersion: 2.2.0
schemaVersion: 2.2.2
metadata:
name: devfile-web
displayName: Devfile Web Services
Expand All @@ -28,7 +28,7 @@ metadata:
- Registry
- Documentation
- devfile.io
version: 1.1.0
version: 1.2.0
components:
- name: image-builder
image:
Expand All @@ -41,16 +41,14 @@ components:
attributes:
container-overrides:
securityContext:
runAsUser: 1001
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for removing this user context? is it just because runAsNonRoot is true and its redundant?

allowPrivilegeEscalation: false
runAsNonRoot: true
capabilities:
drop: ["ALL"]
seccompProfile:
type: "RuntimeDefault"
container:
image: node:22-alpine
command: ['tail', '-f', '/dev/null']
image: quay.io/devfile/universal-developer-image@sha256:99d87fc6f1c9114db7456c419fa4556f63c1c057b6bffde57a1f7429652c7b56
mountSources: true
memoryLimit: "{{memoryLimit}}"
volumeMounts:
Expand Down Expand Up @@ -81,7 +79,10 @@ commands:
# Install dependency packages
- id: build
exec:
commandLine: yarn install --frozen-lockfile --global-folder /.yarn
commandLine: yarn install --immutable
env:
- name: PREFIX
value: /.yarn
component: runner
workingDir: ${PROJECT_SOURCE}
hotReloadCapable: true
Expand Down Expand Up @@ -121,6 +122,6 @@ variables:
# Profile of the image on quay.io
profile: devfile
# Memory limit on runner, default: 1Gi
memoryLimit: 1Gi
memoryLimit: 2Gi
# Deployment configuration to use
deployConfig: development
8 changes: 4 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:

- name: Install
run: |
yarn install --frozen-lockfile
yarn install --immutable

- name: Lint
run: |
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:

- name: Install
run: |
yarn install --frozen-lockfile
yarn install --immutable

- name: Build
run: |
Expand Down Expand Up @@ -126,7 +126,7 @@ jobs:

- name: Install
run: |
yarn install --frozen-lockfile
yarn install --immutable

- name: Docker Build for linux/amd64
run: |
Expand Down Expand Up @@ -159,7 +159,7 @@ jobs:

- name: Install
run: |
yarn install --frozen-lockfile
yarn install --immutable

- name: E2E
run: |
Expand Down
6 changes: 5 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,8 @@ Thumbs.db

.odo/env
.odo/odo-file-index.json
.odo
.odo

# .yarn files
.yarn/install-state.gz
.yarn/cache
Loading
Loading