test: remove test 13 about unfixable vuln#60
Merged
Conversation
Contributor
✅ All test workflows behaved as expected13 passed, 0 failed
|
There was a problem hiding this comment.
Pull request overview
Removes the integration test scenario that asserted workflows should pass when pip-audit reports only “unfixable” vulnerabilities, since that fixture became unstable over time as fixes appeared.
Changes:
- Remove test case 13 (“requirements · flat · unfixable vulns”) from the workflow matrix and expected results.
- Update the validation script’s expected workflow count from 14 → 13.
- Sync
uv.lockto reflectpython-security-auditingversion0.6.0.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updates editable package version entry to 0.6.0. |
| integration-tests/validate_results.py | Updates docstring and EXPECTED_COUNT to 13. |
| integration-tests/expected_results.yml | Removes expected-results entry for test 13. |
| integration-tests/cases/13-requirements-unfixable/requirements.txt | Deletes the pinned vulnerable dependency fixture. |
| integration-tests/cases/13-requirements-unfixable/README.md | Removes documentation for the deleted test case. |
| integration-tests/cases/13-requirements-unfixable/osv-scanner.toml | Removes OSV scanner override tied to the deleted fixture. |
| integration-tests/cases/13-requirements-unfixable/app.py | Deletes the minimal app fixture for the removed test case. |
| .github/workflows/integration-tests.yml | Removes test 13 from the integration test matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the integration test case for handling unfixable vulnerabilities in Python requirements files. The test previously verified that the workflow passes when vulnerabilities exist but no fixes are available. This test is outdated as since its creation a fix is available and the test is now failing. It will be hard to keep an integration test for this usecase as unfixable vulnerabilities don't stay unfixable forever.