Skip to content

test: remove test 13 about unfixable vuln#60

Merged
lhoupert merged 2 commits intomainfrom
tests--fix-vuln-test
Apr 9, 2026
Merged

test: remove test 13 about unfixable vuln#60
lhoupert merged 2 commits intomainfrom
tests--fix-vuln-test

Conversation

@lhoupert
Copy link
Copy Markdown
Collaborator

@lhoupert lhoupert commented Apr 9, 2026

This pull request removes the integration test case for handling unfixable vulnerabilities in Python requirements files. The test previously verified that the workflow passes when vulnerabilities exist but no fixes are available. This test is outdated as since its creation a fix is available and the test is now failing. It will be hard to keep an integration test for this usecase as unfixable vulnerabilities don't stay unfixable forever.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

✅ All test workflows behaved as expected

13 passed, 0 failed

Test Name Expected Actual Bandit pip-audit Result
01 requirements · flat · clean success success
02 requirements · src/ · bandit HIGH failure failure B105, B404, B602
03 requirements · src/+scripts/ · bandit HIGH + pip-audit failure failure B105, B404, B602 cryptography, idna, requests, urllib3
04 uv · flat · clean success success
05 uv · src/ · pip-audit vuln failure failure idna, requests, urllib3
06 uv · src/+scripts/ · bandit MEDIUM failure failure B324, B506
07 poetry · flat · clean success success
08 poetry · src/ · bandit MEDIUM + pip-audit failure failure B105, B324 cryptography, idna, requests, urllib3
09 pipenv · flat · clean success success
10 pipenv · src/+scripts/ · bandit HIGH failure failure B404, B602
11 requirements · flat · clean (root working dir) success success
12 uv · flat · bandit-only (no pip-audit) failure failure B404, B602 disabled
14 uv · flat · low threshold (B101 assert) failure failure B101 disabled

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the integration test scenario that asserted workflows should pass when pip-audit reports only “unfixable” vulnerabilities, since that fixture became unstable over time as fixes appeared.

Changes:

  • Remove test case 13 (“requirements · flat · unfixable vulns”) from the workflow matrix and expected results.
  • Update the validation script’s expected workflow count from 14 → 13.
  • Sync uv.lock to reflect python-security-auditing version 0.6.0.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
uv.lock Updates editable package version entry to 0.6.0.
integration-tests/validate_results.py Updates docstring and EXPECTED_COUNT to 13.
integration-tests/expected_results.yml Removes expected-results entry for test 13.
integration-tests/cases/13-requirements-unfixable/requirements.txt Deletes the pinned vulnerable dependency fixture.
integration-tests/cases/13-requirements-unfixable/README.md Removes documentation for the deleted test case.
integration-tests/cases/13-requirements-unfixable/osv-scanner.toml Removes OSV scanner override tied to the deleted fixture.
integration-tests/cases/13-requirements-unfixable/app.py Deletes the minimal app fixture for the removed test case.
.github/workflows/integration-tests.yml Removes test 13 from the integration test matrix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lhoupert lhoupert merged commit 8fd3aa7 into main Apr 9, 2026
20 checks passed
@lhoupert lhoupert deleted the tests--fix-vuln-test branch April 9, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants