fix: use annotation instead of pr comments#53
Merged
Conversation
Contributor
✅ All test workflows behaved as expected14 passed, 0 failed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cuts down PR notification fatigue by making GitHub Actions annotations the default way to show Bandit and pip-audit results (inline on “Files changed”, no comment emails). PR comments are opt-in via a new
comment_oninput.Behavior
file+line; pip-audit uses summary-level warnings. No email notifications from this path.comment_on(replacespost_pr_comment) — Defaultnever. Useblockingto comment only when the job would fail, oralwaysfor every run (previous “always comment” style).Breaking change
post_pr_comment. Migrate to:comment_on: alwaysif you still want a comment on every run, orcomment_on: blockingif you only want a comment when there are blocking findings.Other
permissions: Default flows no longer needpull-requests: writeunlesscomment_onisblockingoralways.src/python_security_auditing/annotations.py; tests extended accordingly.