Skip to content

docs: say the offline suite runs in the same CI step as bash -n - #36

Merged
developerz-ai[bot] merged 1 commit into
mainfrom
dz/correct-claude-md-the-offline-suite-runs-in-the--56a4d722
Nov 9, 2026
Merged

developerz-ai[bot] merged 1 commit into
mainfrom
dz/correct-claude-md-the-offline-suite-runs-in-the--56a4d722

Conversation

@developerz-ai

@developerz-ai developerz-ai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

What

CLAUDE.md:196-198 told a maintainer the offline suite runs "in the step
after the bash -n loop". .github/workflows/shell-checks.yml:44-56 runs
both in the same run: body, and the workflow's own comment at :29-33
forbids a second job or a second run: step.

Restate the CI section to match the workflow, and sweep the neighbouring
Testing-section claims against .github/run-tests.sh and the workflow
rather than against the old doc text. The workflow file is not touched.

Acceptance

  • CLAUDE.md's CI section states that the offline suite runs in the SAME run: step as the bash -n loop, matching .github/workflows/shell-checks.yml:44-56.
  • No wording anywhere in CLAUDE.md invites a maintainer to move the suite into a second run: step or a second job; grep -n 'step after' CLAUDE.md returns nothing.
  • .github/workflows/shell-checks.yml is unmodified by this pull request (it appears in no declared path and in no diff).
  • Every CI claim in CLAUDE.md matches shell-checks.yml line by line: the bash -n loop (:47-49), bash .github/run-tests.sh (:56), the deliberate-failure probe (:58-79) and bash .github/run-tests_test.sh (:86) all sit in the one step named 'Check Bash syntax and run the offline test suit [trimmed]
  • CLAUDE.md does not claim the runner alone is what that step runs, if the current text implies it; the description matches what the step body executes.
  • CLAUDE.md:121 'all nine today' still matches the nine tests/*.sh files and the runner's default member list (.github/run-tests.sh:40-47) — unchanged or corrected, never contradicted.
  • The runner-contract claims at CLAUDE.md:135-140 (explicit list overrides the default; one process per member; verdict is the exit code alone; a printed SKIP still exits 0 green) still match .github/run-tests.sh:29-47,57-87 plus tests/opencode_config_test.sh:70 and tests/host_memory_test.sh:216.
  • The 'shell-checks is the one check name, listed under pr.required_checks' claim at CLAUDE.md:202-204 still matches .dz/maintainer/maintainer.yml:34-35.
  • bash .github/run-tests.sh exits 0 offline, so the command CLAUDE.md documents still runs the nine members green.
  • The diff touches prose in CLAUDE.md only: no shell code, no workflow, no test script, no docs/ or README change.

Changes

  • CLAUDE.md (edit) — Fix the CI prose at CLAUDE.md:196-198: the offline suite runs in the SAME run: step as the bash -n loop — the step named 'Check Bash syntax and run the offline test suite' (shell-checks.yml:44-56) — not in a later step; drop the phrase 'in the step after the bash -n loop' and mirror the workflow's own rule at :29-33 (no second job, no second run: step). Sweep :182-204 and the suite claims at :119-140 against shell-checks.yml and .github/run-tests.sh; correct anything wrong. Prose only.

Verification

No check command was found for this repository, so no gate ran before the commit.

What the editors ran to see the change working, and what they saw:

  • bash .github/run-tests.sh (redirected to $TMPDIR/mini-suite.log) (docs): EXIT=0 — log ends with 'PASS tests/webfetch.sh', 'PASS: 47 checks', and 'All 9 test script(s) passed.' (nine members, the command CLAUDE.md documents)
  • grep -n 'step after' CLAUDE.md (docs): no output, grep exit 1 — the phrase is gone from the file
  • code_changes (working-tree diff) + code_changes --paths CLAUDE.md (docs): Only CLAUDE.md is modified; the diff is one prose hunk in the ## CI section (lines 195-208). .github/workflows/shell-checks.yml, .github/run-tests.sh, docs/ and README.md appear in no diff.
  • code_read CLAUDE.md (CI section, lines 182-212) (docs): CI section now states the suite rides in the SAME step as the bash -n loop (step named 'Check Bash syntax and run the offline test suite'), lists that step body's four commands (bash -n loop, bash .github/run-tests.sh, the deliberately-failing-member probe, bash .github/run-tests_test.sh), and keeps the 'shell-checks is the one check name' paragraph intact

Notes

Premises of the request the team disproved:

  • The request implies further drift at CLAUDE.md:121 and :133 — none is there: :121 'all nine today' matches the nine tests/*.sh files and the runner's default list (.github/run-tests.sh:40-47), and :133's webfetch row names a real member. The only wrong CI claim in the file is :196-198.
  • The request's 'sweep' may imply the drift is repo-wide — it is not: docs/*.md and README.md make no CI claim at all, and .claude/commands/feature.md:103 describes the shell-checks job at job level accurately. Scope stays on CLAUDE.md.

🤖 Opened by developerz.ai for task tsk_56a4d72257d7f8f18efa4f296f991919 on developerz-ai/mini.

Raised automatically by the raw_task_triage lane.

🤖 developerz.ai, an automated agent, not a human — this PR is one slice of a stacked plan.
Dispatched automatically by the raw_task_triage lane
Model MiniMax-M3 on api.minimax.io via native, funded by account_key
Ran on box hv-dedicated-ci-0
Cost ~$0.12 for 787.4k in / 39.2k out (estimate: list price x reported tokens, cached input at its cached rate)
Run timeline run_ff948babad92492c94a8ef9f1be19d87
Part 1/1 of plan rtk_e17ea39c8f024ee394de3d733ab43f81

CLAUDE.md:196-198 told a maintainer the offline suite runs "in the step
after the `bash -n` loop". .github/workflows/shell-checks.yml:44-56 runs
both in the same `run:` body, and the workflow's own comment at :29-33
forbids a second job or a second `run:` step.

Restate the CI section to match the workflow, and sweep the neighbouring
Testing-section claims against .github/run-tests.sh and the workflow
rather than against the old doc text. The workflow file is not touched.

Dz-Task-Id: tsk_56a4d72257d7f8f18efa4f296f991919
@developerz-ai developerz-ai Bot added dz/fleet-pr Opened by developerz.ai, an automated agent, from a fleet run. dz/model:MiniMax-M3 developerz.ai: model that wrote this bot PR. dz/provider:api.minimax.io developerz.ai: provider that served this bot PR. labels Nov 9, 2026
@developerz-ai

developerz-ai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Reviewed — nothing blocking

0 actionable comment(s) · grounded on your code

⚠️ 1 config note(s): test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against

⏱ 59s wall clock · deepseek-v4.1-flash via router · 1 model call(s) · 3,559 output token(s)

🤖 developerz.ai — automated review, running on your model and your box.

@developerz-ai developerz-ai Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary — 1 file(s), 0 finding(s).

Rewrites CLAUDE.md's CI section so the offline suite is documented as riding in the same run: step as the bash -n loop, and lists that step's four commands. Prose only: no shell code, workflow or test change, and the new claims stay consistent with the file's Testing section.

  • test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against

🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by router/deepseek-v4.1-flash on box hv-dedicated-ci-1 — 15.3k in / 3.56k out over 1 call, on your flat-rate plan: no per-token charge (~<$0.01 at list price).

@developerz-ai
developerz-ai Bot merged commit ef9f7ce into main Nov 9, 2026
3 checks passed
@developerz-ai
developerz-ai Bot deleted the dz/correct-claude-md-the-offline-suite-runs-in-the--56a4d722 branch November 9, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dz/fleet-pr Opened by developerz.ai, an automated agent, from a fleet run. dz/model:MiniMax-M3 developerz.ai: model that wrote this bot PR. dz/provider:api.minimax.io developerz.ai: provider that served this bot PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants