π‘οΈ Sentinel: [HIGH] Fix command injection in directory picker - #1
π‘οΈ Sentinel: [HIGH] Fix command injection in directory picker#1devdudumuniz wants to merge 1 commit into
Conversation
π¨ Severity: HIGH π‘ Vulnerability: Command injection in `_native_dir_picker` due to unescaped user inputs (`title` and `initialdir`) being directly interpolated into PowerShell and AppleScript strings. π― Impact: A malicious user could provide crafted input strings that break out of the string literal and execute arbitrary commands on the host machine. π§ Fix: Added proper escaping for single quotes in PowerShell (`''`) and double quotes/backslashes in AppleScript (`\"` and `\\`). β Verification: Ran `pytest pysus/tests/` to ensure no regressions. Verified locally that payload execution is stopped and tests pass.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Superseded by the reviewed and validated upstream contribution AlertaDengue#336. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Command injection in
_native_dir_pickerdue to unescaped user inputs (titleandinitialdir) being directly interpolated into PowerShell and AppleScript strings.π― Impact: A malicious user could provide crafted input strings that break out of the string literal and execute arbitrary commands on the host machine.
π§ Fix: Added proper escaping for single quotes in PowerShell (
'') and double quotes/backslashes in AppleScript (\"and\\).β Verification: Ran
pytest pysus/tests/to ensure no regressions. Verified locally that payload execution is stopped and tests pass.PR created automatically by Jules for task 4557003205665608159 started by @devdudumuniz