Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection in directory picker - #1

Closed
devdudumuniz wants to merge 1 commit into
mainfrom
sentinel-fix-command-injection-4557003205665608159
Closed

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection in directory picker#1
devdudumuniz wants to merge 1 commit into
mainfrom
sentinel-fix-command-injection-4557003205665608159

Conversation

@devdudumuniz

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Command injection in _native_dir_picker due to unescaped user inputs (title and initialdir) being directly interpolated into PowerShell and AppleScript strings.
🎯 Impact: A malicious user could provide crafted input strings that break out of the string literal and execute arbitrary commands on the host machine.
πŸ”§ Fix: Added proper escaping for single quotes in PowerShell ('') and double quotes/backslashes in AppleScript (\" and \\).
βœ… Verification: Ran pytest pysus/tests/ to ensure no regressions. Verified locally that payload execution is stopped and tests pass.


PR created automatically by Jules for task 4557003205665608159 started by @devdudumuniz

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Command injection in `_native_dir_picker` due to unescaped user inputs (`title` and `initialdir`) being directly interpolated into PowerShell and AppleScript strings.
🎯 Impact: A malicious user could provide crafted input strings that break out of the string literal and execute arbitrary commands on the host machine.
πŸ”§ Fix: Added proper escaping for single quotes in PowerShell (`''`) and double quotes/backslashes in AppleScript (`\"` and `\\`).
βœ… Verification: Ran `pytest pysus/tests/` to ensure no regressions. Verified locally that payload execution is stopped and tests pass.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@devdudumuniz

Copy link
Copy Markdown
Owner Author

Superseded by the reviewed and validated upstream contribution AlertaDengue#336.

@devdudumuniz
devdudumuniz deleted the sentinel-fix-command-injection-4557003205665608159 branch August 30, 2026 01:27
@google-labs-jules

Copy link
Copy Markdown

Superseded by the reviewed and validated upstream contribution AlertaDengue#336.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant