Repository navigation
Make a provider switch clear its settings and show at once in the TUI - #70
Merged
Merged
Conversation
thesiti92
force-pushed
the
tui-refresh-settings
branch
from
October 1, 2026 18:10
b50bc1a to
d8265dc
Compare
sidkmenon
approved these changes
Oct 1, 2026
thesiti92
force-pushed
the
tui-refresh-settings
branch
from
October 1, 2026 19:06
1b334cd to
455e9fd
Compare
A change can move other values, such as a model default that follows the provider, so the settings screen rereads config show after each write instead of updating only the edited row.
Options marked x-reset-by = "provider" are cleared by config set when the provider takes a new value, so a switch in the TUI or the CLI never sends the old vendor's key to the new one or to its endpoint. The prompt and general settings stay.
thesiti92
force-pushed
the
tui-refresh-settings
branch
from
October 2, 2026 18:20
455e9fd to
fa07547
Compare
sidkmenon
approved these changes
Oct 2, 2026
thesiti92
enabled auto-merge (squash)
October 2, 2026 18:20
sidkmenon
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found testing 0.1.9 in the TUI against Whiteboard's settings.
Changes
api_key,endpoint,modelandprovider_detailsare markedx-reset-by = "provider".config setclears them when the provider takes a new value, so a switch in the TUI or the CLI no longer sends the old vendor's key to the new vendor, or to the old vendor's endpoint. The prompt and general settings (thresholds, tests, timeouts) stay. Setting the same provider again changes nothing. The manifest check rejects anx-reset-bythat names no other option.Verified
cargo testpasses. The TUI suite passes apart from the shutdown signal test, which also fails on main locally.For Whiteboard's next diffr bump: Whiteboard's save skips writes equal to values it read before saving. Once diffr clears the endpoint on a provider change, a custom endpoint kept across a switch would be skipped and lost. Its writes need to compare against values reread after each write.