feat/github-cli: support Alpine based images - #1739
Open
Mark S. (the-wondersmith) wants to merge 8 commits into
Open
Mark S. (the-wondersmith) wants to merge 8 commits into
Mark S. (the-wondersmith) wants to merge 8 commits into
Conversation
Tecnically also adds generic, extensible support for *any* linux-flavor base image.
Author
|
@microsoft-github-policy-service agree |
Author
|
As noted in the PR description, if this is accepted I'm happy to tackle:
and generally adding Alpine support across the board (incrementally). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR adds support for using the
github-clifeature with Alpine based images.Note
PR technically implements an extensible pattern for implementing support for other currently unsupported linux flavors. That's more of a side effect / happy accident than actual intention. That said, if the
devcontainers/featuresmaintainers don't have objections, I will happily extend it to the other single-distro (read: debian) features if this PR is accepted. 😅