Fix InvalidDefaultArgInFrom docker warning when updateRemoteUserUID is enabled#1245
Open
felipecrs wants to merge 1 commit into
Open
Fix InvalidDefaultArgInFrom docker warning when updateRemoteUserUID is enabled#1245felipecrs wants to merge 1 commit into
felipecrs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This warning is silly as the
BASE_IMAGEwill always be set in this case.It's however always emitted for end users, and they have no control over it, so it's better we supress it.
I could also use the
# check=skip=InvalidDefaultArgInFromcomment, but it would apply to the whole file, so I think this is cleaner.scratchis an empty docker image.Otherwise this is what happens: