fix: relative symlink resolution in install script#1244
Draft
V-Subhankar-infy wants to merge 1 commit into
Draft
fix: relative symlink resolution in install script#1244V-Subhankar-infy wants to merge 1 commit into
V-Subhankar-infy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes relative symlink resolution in the install script for split local install layouts, such as a symlinked launcher in ~/.local/bin and the CLI payload in ~/.local/lib/devcontainers. With this change, devcontainer resolves paths correctly regardless of the caller’s current working directory.
Fixes #1232
Issue Context
Issue #1232 describes a failure in this setup:
Observed error:
Root Cause
The wrapper could resolve a relative symlink target before canonicalizing the path. As a result, later path derivation could depend on the current working directory, which caused failures in split local install layouts.
Reproduction (Compact)
Fix (Single-Line Change)
Why This Fix Works
By preferring canonical resolution first, the wrapper gets an absolute and normalized script path whenever possible. This makes installation path derivation independent of the caller’s working directory, so relative symlink launches resolve correctly.
Validation
A regression test verifies that:
Scope and Risk