Repository navigation
Conversation
Adds patch (1), upstream (5), sudoers (25), and mknod (100) badges for developers who got patches merged into nunomaduro/dev-null.sh. An hourly job reads GitHub's contributor list and keeps it in the cache for a day; profiles only read that cache. No XP.
paulinevos
reviewed
Oct 22, 2026
|
The issue proposal says we should also count issues/commits/pull requests. |
Contributor
Author
|
@nunomaduro @paulinevos Feedback addressed ya. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recognize developers who contribute to /dev/null with one contributor achievement badge.
Addresses @paulinevos's review feedback: replaces the four proposed tiers with one badge and uses wording that covers features, bug fixes, documentation, and other merged changes.
Related to #894 and #442. This covers GitHub-credited commits, including merged pull requests. Issue-only activity, reviews, and unmerged pull requests are not counted, so it does not fully implement the broader proposal in #894.
Changes
contributorbadge, unlocked at the first GitHub-credited contribution, with no bonus XP.productionand resolve the knowledge-base/test conflicts while preserving the shell-shocked and super-saiyan badges and existing achievement UI.Validation
Local checks on
98dfac9f9519692f60e2445da252a74fd5d491e0:composer test:lint— passed; existing warnings in unrelated files remain.composer test:type-coverage— passed, 100%.composer test:types— passed (PHPStan and TypeScript).bun run test:unit— passed.bun run build— passed.php vendor/bin/pest --ci tests/Unit/Queries/UserAchievementsQueryTest.php tests/Unit/Jobs/SyncUpstreamContributionsTest.php— 44 passed, 301 assertions.php -d extension=/private/tmp/pcov-build/pcov-1.0.12/modules/pcov.so -d memory_limit=-1 vendor/bin/pest --parallel --ci --coverage --exactly=100.0 --passthru-php="'-d' 'memory_limit=-1' '-d' 'extension=/private/tmp/pcov-build/pcov-1.0.12/modules/pcov.so'"git diff --check— passed.No controls, styles, motion, or mobile interactions were changed; the badge uses the existing data-driven achievement components. Browser visual and physical-device checks were not run.
Independent review
Read-only review by a separate GPT-6.1 Sol reviewer: Code PASS, no blocking findings across the complete 10-file diff.
3a9a137426176a3a93d7fb2afcdee7e269a5ff4c98dfac9f9519692f60e2445da252a74fd5d491e0Limitations
composer installwas blocked; locked dependencies were installed for local verification with--ignore-platform-req=php. No lockfile, security advisory, or global PHP configuration was changed.