Repository navigation
feat: add follow button to contributor cards on about page - #1100
Open
tooinfinity wants to merge 1 commit into
Open
tooinfinity wants to merge 1 commit into
tooinfinity wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a follow icon button to each contributor card on
/aboutso users can follow contributors directly on /dev/null, matching the "Who to follow" style.Changes
resources/js/pages/about/show.tsx: AddedFollowIconButtonto contributor cards while preserving the 3-columns-per-row grid layout; hidden on the user's own card.resources/js/components/follow-button.tsx: Handled guests (signIn()) and contributors not yet registered on /dev/null (toast notification on 404).app/Http/Controllers/AboutController.php: PassedfollowingLoginslazy prop to initialize following states.ContributorCard.test.tsx) and feature test (AboutControllerTest.php).Validation
bun run test:types— Passedbun run test:lint— Passedbun run test:unit— Passed./node_modules/.bin/vp test tests/Unit/ContributorCard.test.tsx— Passed./vendor/bin/pest tests/Feature/Controllers/AboutControllerTest.php— PassedVisual evidence