Repository navigation
fix: expand issue references only when selected - #1098
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Typing
#722and then Space or punctuation used to replace the number with a GitHub URL, including when a delayed lookup finished after more text was typed. Keep the text literal until the author selects the suggestion with Enter, Tab, or a click, matching emoji suggestions.Changes
Validation
composer test:lint,composer test:type-coverage(100%),bun run test:unit(153 tests),bun run test:types, andbun run build: passed.Visual evidence
Local demo data; before is
productionat722488ea3d7e67ff82b5f45467187d4cdbb35fa2, after is03dce95c6bd1ad469980a09ebb0d023ad16fcdc9. Desktop recordings are Chrome at 1280×800 with cursor/key overlays. Screenshots are 2× desktop 1440×900, laptop 1366×650, and mobile 390×844 viewport emulation, in light and dark.Before: Space expands the reference
Before MP4
After: Space stays literal, Enter and Tab select
After MP4
Main composer after Space: full before/after viewport and theme matrix
Main composer suggestion: full before/after viewport and theme matrix
Reply suggestion: full before/after viewport and theme matrix
Quote suggestion: full before/after viewport and theme matrix
Remotes suggestion: full before/after viewport and theme matrix
Suggestion, Space, Enter and Tab interactions, navigation, and the idle cycle measured 0 CLS in the final six-case matrix. The exact base and head have identical nonzero first-load CLS: 0.0035268 desktop, 0.0054267 laptop, 0.0306681 mobile. Existing link-preview controls can also move after delayed updates (observed on both revisions); those pre-existing layout issues remain outside this input-behavior change. No page-level JavaScript exceptions were observed. Local sign-in produces an expected Inertia HTTP 409 location response in both captures.
Device verification
iPhone 18 Pro, iOS 27.0 Simulator, Safari: on-screen Space leaves
#722literal; Backspace reopens the suggestion; Return inserts its URL. The keyboard stays open and the Commit action remains visible. Scrolling beyond the first screen and a client-side Following transition were checked. Native evidence covers the common textarea in the main composer; the other composers have viewport emulation coverage.Native MP4, idle intervals cut
Independent review
CODE: PASS · VISUAL: PASS · OVERALL: PASS from an independent Sol 6.1 reviewer with high reasoning and fast service.
Reviewed base
722488ea3d7e67ff82b5f45467187d4cdbb35fa2and head03dce95c6bd1ad469980a09ebb0d023ad16fcdc9; all 71 frozen media hashes verified against manifest SHA256969f8f402c468d4c6efa1c71c2a95e319a20e9bac39d3bfc9cac6ec163bb4c18.The reviewer independently reran the 16 focused tests, compared exact-base/head browser behavior across all six viewport/theme combinations, exercised the reply/quote/Remotes consumers and delayed lookup cases, and inspected screenshot matrices, native screenshots, and sampled frames from all three recording pairs. No actionable findings. Broad checks were assessed from the supplied logs; native evidence was supplied simulator evidence, and recordings were sampled rather than reviewed frame by frame.
Limitations