Write the changepack log without a BOM - #201
Merged
Merged
Conversation
PowerShell's Set-Content wrote a UTF-8 byte order mark, and changepacks rejects it: 'Failed to parse changepack log ...: expected value at line 1 column 1'. Because the workflow runs on pull_request_target it reads this file from main, so every pull request fails its changepacks check until main itself is repaired. Match the single-line shape the other logs use.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.changepacks/changepack_log_F7sKFk0VHuuAuj0_bSvZ7.json가 UTF-8 BOM 으로 시작해서 changepacks 가 읽지 못한다.PowerShell 의
Set-Content -Encoding UTF8이 BOM 을 붙인 것이고, 다른 changepack 로그 네 개에는 BOM 이 없다.모든 PR 이 이것 때문에 막힌다.
publish.yml의 changepacks job 은pull_request_target으로 돌아 워크플로와 체크아웃을 base(main)에서 가져오므로, PR 안에서 파일을 고쳐도 job 은 여전히 main 의 BOM 파일을 읽는다. main 을 고쳐야 풀린다.BOM 을 없애고 다른 로그들이 쓰는 한 줄 형식으로 맞췄다. 내용(
changes/note/date)은 그대로다.