Repository navigation
Conversation
All 12 matrix jobs have failed at the Ruff step since 2026-11-07. - fix 23 Ruff findings; narrow blind exception handlers to the expected file, data, XML and Tk errors, no lint rule disabled - fall back to tomli on Python 3.10 where tomllib is not in the stdlib - declare Pillow as a dev/CI dependency for tests/test_app_assets.py - WACK preflight timestamps carry the local UTC offset Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01THB2F17eZ5jWcC9snC7oi1
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01THB2F17eZ5jWcC9snC7oi1
|
Welcome! 👋 Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
lukisch
commented
Nov 11, 2026
lukisch
left a comment
Collaborator
Author
There was a problem hiding this comment.
Zweitprüfung (Cloud-Bot) – Head 85e6196
Hinweis: Der PR stammt aus einem früheren Bot-Lauf (claude/…-Branch, gleiche GitHub-Identität). Das ist keine unabhängige Prüfung und keine formale Freigabe.
Ergebnis: freigabefähig, keine blockierenden Befunde.
- Lokal auf Python 3.10 (Tk 9.0, Pillow 12.3.0,
xvfb-run):ruff check .sauber,compileallsauber,pytest295 bestanden / 10 übersprungen (PEP 695). Das deckt sich mit der PR-Beschreibung. - Python 3.11–3.13, Windows und macOS lokal nicht ausgeführt. Dafür gilt die grüne 12er-Matrix.
- Eingeengte
except-Blöcke gegen den geschützten Code geprüft:MethodenAnalyser3.py:2407,manage_translations.py:25/88/131/158,scripts/check_store_readiness.py:187,scripts/run_windows_wack.py:102/165. Die erwartbaren Fehler (OSError, JSON-/Unicode-Fehler als ValueError,ET.ParseError,TclError) bleiben abgedeckt.
Nicht blockierend:
scripts/check_store_readiness.py:17-20: Dertomli-Fallback hängt auf Python 3.10 an einer transitiven pytest-Abhängigkeit.tomli; python_version < "3.11"gehört explizit inpyproject.toml(dev) undrequirements-dev.txt, sonst scheitert das Skript ohne pytest.scripts/run_windows_wack.py:83:.astimezone()vorstrftime("%Y%m%d")ist wirkungslos. Relevant ist nur die Änderung in Zeile 304.- Bestätigt: Der Testlauf schreibt
releases/windowsstore/test_reports/wack_preflight_<Datum>.xmlin den getrackten Baum. Das bestand schon vorher; der Test sollte in einem Folge-PR auftmp_pathumgestellt werden.
Nicht gemergt; die Freigabe liegt beim Maintainer.
Generated by Claude Code
Collaborator
Author
|
Zu den drei nicht blockierenden Hinweisen aus der Zweitprüfung (Head
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MethodenAnalyser smoke testsis red onmastersincedf464bf(2026-11-07). All 12 matrix jobs fail within a minute, before any test runs.Reproduced locally on
masterwithruff 0.16.9:ruff check .reports 23 findings. Two more failures sit behind the lint step:tests/test_security_license_contract.pyandscripts/check_store_readiness.pyimporttomllib, which does not exist on Python 3.10 (four of the twelve cells).tests/test_app_assets.pyimportsPIL, but the workflow only installspytestandruff.#8 addressed the same three causes on 2026-10-15, but it conflicts with
masterand predates 17 of the 23 findings. This PR takes its approach onto the currentmaster; #8 can be closed once this lands.Changes
except Exceptionhandlers now catch the errors the guarded code can raise:OSError/ValueErrorfor file and JSON loading, plusTypeErrorfor the atomic JSON write,ET.ParseErrorfor manifest parsing,tk.TclErrorfor the report dialog,AttributeError/OSErrorfor the admin check. The rest is import ordering, one mergedisinstance, an explicitcheck=False, and a shebang removed from a non-executable script.tomlifallback in the twotomllibimporters.tomliis a dependency of pytest on 3.10.pyproject.toml(dev),requirements-dev.txtand the workflow install step. Runtime stays stdlib-only.scripts/run_windows_wack.py: report timestamps now usedatetime.now().astimezone(), so the ISO timestamp carries the local UTC offset. The date in the file name is unchanged.Verification
ruff check .: clean (was 23 findings).python -m compileall -q .: clean.xvfb-run: 295 passed, 10 skipped (all PEP 695, need 3.12+), 15 subtests passed.tkinterin this environment. The matrix on this PR is the evidence for them.Notes for the reviewer
test_run_windows_wack_preflight_passeswritesreleases/windowsstore/test_reports/wack_preflight_<date>.xmlinto the repository tree on every run, and that directory is tracked. I removed the file my run produced (second commit) and did not change the test.Generated by Claude Code