feat(mgmt-scim): concrete OutboundSCIMConfigurationData TypedDict#1624
Merged
dorsha merged 2 commits intoJul 16, 2026
Merged
Conversation
Match the typed configuration shape shipped in go-sdk#798 / node-sdk#765. Add descope/management/outbound_scim_types.py with TypedDict definitions mirroring the SCIM connector template (content/connectors/templates/scim/metadata.json): baseUrl, ignoreUnverifiedPhones/Emails, userMapping, authentication (tagged by method, per-method sub-shapes for bearerToken / apiKey / basicAuth / oauth2ClientCredentials), headers, hmacSecret, aws* signing, rfc9421* signing, insecure. create_configuration / update_configuration signatures (sync + async) accept the TypedDict so callers get IDE/mypy completion. Runtime behavior unchanged — TypedDict is validation-free. Docstrings call out which fields are secret-typed and returned masked on Load. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
🐕 Review complete — View session on Shuni Portal 🐾 |
![shuni-bot[bot]](https://avatars.githubusercontent.com/in/2536750?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🐕 Shuni's Review
Adds a concrete OutboundSCIMConfigurationData TypedDict and wires it into create_/update_configuration. Runtime behavior unchanged — clean, focused change with good bones.
Sniffed out 1 issue:
- 1 🟡 MEDIUM:
NotRequiredimported but never used (dead conditional import)
See inline comment for details. Woof!
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)descope/management/outbound_scim_types.py
descope/management/outbound_scim.py
descope/management/outbound_scim_async.py
descope/management/_outbound_scim_base.py
|
Shuni review — every TypedDict uses total=False, never NotRequired, so the sys/typing_extensions import guard was dead code and tripped ruff F401 in CI. On the declared 3.9 floor the else-branch would also have pulled in typing_extensions, which isn't a declared dependency. Literal and TypedDict are both stdlib since 3.8 — plain from-typing import is enough. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code