Add Russian name official order handling - #154
Closed
me21 wants to merge 3 commits into
Closed
Conversation
added 3 commits
May 27, 2024 13:35
…al configuration parameter that is False by default. Signed-off-by: Alexander Zarubkin <alexander.zarubkin@toptal.com>
Signed-off-by: Alexander Zarubkin <alexander.zarubkin@toptal.com>
Signed-off-by: Alexander Zarubkin <alexander.zarubkin@toptal.com>
Owner
|
Closing in favor of #184 |
derek73
added a commit
that referenced
this pull request
Aug 16, 2026
Sweeping session memories against the new docs surfaced one more falsification from the docs' own author: P2's 'join runs to the end' is wrong for multi-group names -- a second particle starts a new group and groups distribute positionally (the v1 Portuguese tests pin it; 'Vincent van Gogh van Beethoven' → middle='van Gogh'), with the #132 combined reading living in the surnames view (now assertable and pinned). Promoted from memories: O1's opt-in rationale (PR #154's Martin/Franklin/Benjamin finding), the comma-suffix bundle's ship+repair amendment, the 2026-07-06 api-churn declines and the 3.0 config parking lot (contextvars scoped override; Parser(constants) with #262's contract framing), the bytes removal record, the property-key pickle skip's dies-with-shim note, and the tags-are-ground-truth verification field note (the twice-recurred 1.2.1-shim mix-up). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official name order in Russia is Last First Middle without comma.
This pull request hopefully fixes #85, but some corner cases may remain.
It is enabled by additional configuration parameter as in its current form it breaks some tests if applied unconditionally. Please see tests for examples.