Repository navigation
Read Dutch Oude by default and ten under a new locales.NL pack (#1455) - #1460
Merged
Merged
Conversation
) oude is a particle on by default (nl.toml), with a given reading for nam_dict's rare Dutch given name and the case mask Oude, so Piet Oude Luttikhuis gives family 'Oude Luttikhuis'. ten is nl.toml's preposition written default = false, with zh.toml declaring the Chinese given-name syllable it opens, so locales.NL, a new pack choosing nl alone, reads Jan ten Brink with family 'ten Brink' and a leading Ten stays given, reported, save under strict=True. The pack's choice also drops en's credential VD for vd's particle. Registered, with rotators, contents, pickling, case-repair and strict tests, the CLDR locale view's nl file (22/24 with and without the pack), and ten in the reviewed table of words a strict choice ungates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
decisions/vocabulary-collisions gains two Standing lines and a dated entry with every figure's recipe: oude 16 fixed to 1 broken by default, ten 86 to 9 under the pack (the Netherlands 66 to 4), strict nl's gap. rules/P2 records the Chinese-syllable cost under the pack, rules/R4 oude's mask; the rules corpus and snapshot gain the four examples, no existing name moving. The vocab README names oude as the one generic particle. docs/languages.rst gains a Dutch section, docs/locales.rst the pack's rows, migrate.rst a Changed in 3.2 entry, the release log two bullets; customize.rst's unlisted-particle example moves from ten to in. Case rows for both words, checked against the 1.4.0 and 3.1.0 wheels. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The review findings. Records: the decisions entry re-takes its diff at head (the default 26, plain:NL 250, strict:NL 254, the two reading 34 names apart) and counts moved names by the word they hold; says which calls were the builder's (oude's kind and given reading, ten's given reading in zh.toml) apart from the two decision comments; states ten's case on all three sources; drops 'always before another surname word' for oude (two boxes end in De Oude); names the two scored mid-name breaks; records the strict comma costs and the pack's VD comma cost, and the name match's moves. rules/P2's bullet carries that count, dated, with only its cost and a boundary in its fence. Docs: languages.rst's scope, counts and costs; migrate.rst's 3.2 scope and table row, and Oude's new report; the release log's VD comma form; nl.py's docstring; the vocab README's wording; zh.toml's Bhutanese names. Tests: case rows for the two-run cost and VD (bare and after a comma); strict keeps a leading Oude given; zh's given reading of ten moves no default parse (with its negative control under the pack); the match pairs, written as tuples so match_diff draws them (1,254 of 690,426 rows move, each a pair holding Piet Oude Luttikhuis). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The 20 fixes are those outside the Netherlands, not outside it and Belgium; rules/P2 pairs the nine breaks with the 86 fixes over the same records; the match account adds the one verdict that moved the other way (Piet Oude Luttikhuis against Piet Luttikhuis under -particles-aside, as van already reads) and the two plain/strict differences outside the shapes it named. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
The four choices listed under "What the decisions did not settle" are accepted as made (2026-11-18): the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1455
Builds the three decisions recorded on the issue on 2026-11-18:
oudeis a particle in the default vocabulary (nl.toml), with the case maskOude.parse("Piet Oude Luttikhuis")gives familyOude Luttikhuis, where 1.4.0 through 3.1.0 gave middleOude.tenis an nl.toml preposition writtendefault = false, with agivenreading beside it. The given reading is declared in zh.toml (see below). The default parse of a name holdingtenis unchanged.locales.NLships, a pack choosingnlalone.parser_for(locales.NL).parse("Jan ten Brink")gives familyten Brink.The kind chosen for
oude, and whyoudeuses the genericparticlekind (particle = {}).Oude Luttikhuis,Oude Elferink).preposition,article,patronymic,teknonymic,clan,rank,saint,alias). None of them describes an adjective.PARTICLES, apart fromrankandsaint. Those two are written with a capital by kind, andoudeis neither. So the choice is descriptive only and moves no parse.qualifier, say) for the Low Saxon farm-name qualifiers (Groot,Klein,Lütke). That adds a publicLexicon.words(kind=...)value for one vetted word, so I left it for when those words are vetted. The vocab README now namesoudeas the one generic particle reading.What the decisions did not settle (my calls, open to review)
oudecarries agivenreading. The vetting found nam_dict listsOudeas a given name (band 1, the Netherlands). The README's C-i rule treats one attested bearer as settling the may-be-given side.oudeis therefore a particle that may be given. Opening a name it stays the given name and reports the fork (Oude Luttikhuis→ givenOude,particle-or-given), asvandoes.Oude Luttikhuisas family, unreported. That is one line in nl.toml.ten'sgivenreading is in zh.toml, not nl.toml.givenreading beside it". I read that as on the word, placed in the file whose names carry it. This follows how Latinben(given reading in en.toml) andsushri(or.toml) were placed, and the RFC'sin/toplan. No file holds Dzongkha, so the Bhutanese bearers are noted in zh.toml's entry.nlchoice keeps a leadingTengiven, reported. A strictnlchoice reads no zh.toml, so a leadingTenis the family name (Ten Kao Liu→ familyTen Kao Liu).tentherefore joinsSTRICT_UNGATED["nl"]in tests/v2/test_reading_index.py.nlturns off other files' vocabulary readings of words nl.toml holds, sovd(van der) loses en.toml's VD (Volunteer Decoration):John Smith VDgives familyVDunder the pack. After a comma it costs more:John Smith, VDreads the whole name as the family (asJohn Smith, dedoes by default). This is the same mechanism aslocales.ARandABD. The docstring, docs/languages.rst and the release log say so, with theenremedy as a doctest, and case rows pin both forms.tenas its example of an unlisted particle. It now uses Dutchin(in 't Veld), which no file holds.Measurements (all 2026-11-18, py3.11, against master
688991e7)The comparator for master is
expr:Parser(lexicon=Lexicon.default().remove('oude')). Its 36 compiled sets equal master's, dumped in both trees and compared. The only difference isoude's case mask, which no compared field reads.Default (
oude)tests/v2/test_snapshot.pysnapshot.py --record).uv run python tools/differential/cldr_agreement.py --recordconfig_diff.py diff "expr:…remove('oude')" default plain:NL strict:NL --committed --local all --match '(?i)(^|[\s,.(])(ten|oude|vd)([\s,.)]|$)', 370 names at headoudemiddle→family: 25 local (the vetting's 22 plus 3 in ctgov-contacts, a corpus fetched since, #1454) and 1 committed, this PR's own rules/R4 example. No name holdingtenmoves by default.config_diff.py score "expr:…remove('oude')" default plain:NL strict:NL --cap 20000, 434 groups ≥100Oudeinto the given box. This confirms the vetting's 16/1.The pack (
locales.NL)plain:NLmoves 250 names (holdingten206,oude26,vd18);strict:NLmoves 254 (208, 26, 20). The two read 34 names differently, 24 holdingten: under strict a leadingTen, or one opening the given part after a family comma, reads as the family.plain:NLfixes 102 / 10 against master. Subtractingoudeleavesten(andvd) at 86 / 9, matching the vetting: Netherlands and Dutch filers 66 / 4 (ORCID NL 31/0, PatentsView NL 28/4, PSC Dutch 7/0), Belgium 2/0, everyone else 18/5. Read one by one, two of the nine breaks are the mid-name syllable (PatentsView MYKheng Ten Choo, SGTerence Ten Teck Hong); the other seven are filers who typedtenat the end of the given box.config_diff.py gaps nlel,di,al,le,da);tenis not among the top 20 words.nlfile reads 22/24 with and without the pack; recorded incldr_agreement_locales.json.Suggester and name match (
oudejoins the particle set both read)suggest_measure.py --base <master checkout>: 0 cells moved.match_diff.py --base <master checkout>: 0 of 690,382 rows moved before any test pair heldoude. With the two pairs this PR adds to tests/v2/test_match.py, written as tuples so the tool draws them: 1,254 of 690,426 rows move (57 under each of the 22 settings). Every one is a pair holdingPiet Oude Luttikhuis, whose keys gainoudeluttikhuis;pand whose middleOudeempties.Piet Oudeluttikhuisis now consistent (familyjoined) where master read a conflict, andPiet Luttikhuissets the particle aside. The key guarantee holds: 0 consistent pairs share no key.Strict
parser_for(locales.NL, strict=True)readstenas a never-given particle. A leadingTenbecomes the family name (Ten Brink,Ten Kao Liu,, Ten Brink,Brink, Ten Jan→ familyBrink Ten Jan).Tenfolds into the family under strict (Brink, Ten Jan,, Ten Brink,SWACKHAMER, TEN EYCK). docs/languages.rst and the decisions entry record this as a cost.oudekeeps its given reading, since that reading is in nl.toml (pinned by a test).STRICT_UNGATED["nl"]moves from{den, tho}to{den, ten, tho}.Sweeps (nameparser/AGENTS.md)
Both words, each comma shape × each
name_order× {default,locales.NL, strict NL}, one-case and mixed-case, plus case repair plain and forced. The full grid is reproducible with a short script (in the session scratchpad). Summary:ten, default: unchanged from master in every shape.ten, under the pack:Jan ten Brink→ familyten Brinkunder every order. Under FAMILY_FIRST it becomes giventen Brink, the particle chain.Ten Brink,Ten Wei Ming,Ten K. Smith,Ten John).Brink, Jan ten→ familyten Brink, reported (P6).Brink, Ten Jankeeps givenTen.J. Ten Smithkeeps givenJ.Park Ten HwanandKheng Ten Choo→ familyTen …(now in rules/P2's Accepted).ten's given reading moves no default parse: a parametrized test comparesParser()with the reading removed, over 12 shapes × 3 orders, with a negative control under the pack.ten, the vetting's section-5 shapes that read wrongly without a given reading:Ten Wei Ming,Ten K. Smith,Ten John,Brink, Ten Janand, Ten Brinkall read givenTenunder plain NL. Under strict NL they read as family, which is the strict cost above.oude, all configs:Oude Luttikhuisunder every order; after a family comma it reads family, reported.Oude Luttikhuis,Oude Wei Ming) it stays given and is reported.Jan de Oude Brink→ familyde Oude Brink.Van Oude Luttikhuis→ givenVan(reported), familyOude Luttikhuis.Case repair (
capitalized()andcapitalized(force=True)):PIET OUDE LUTTIKHUIS,piet oude luttikhuisPiet Oude LuttikhuisPiet Oude LuttikhuisJAN DE OUDE BRINKJan de Oude BrinkJan de Oude BrinkVAN OUDE LUTTIKHUISVan Oude LuttikhuisVan Oude LuttikhuisJAN TEN BRINK,BRINK, JAN TENJan Ten BrinkJan ten BrinkTEN BRINKTen BrinkTen Brink(given); strict:ten Brink(the whole family)Jan Ten BrinkJan ten BrinkFound, not fixed (an existing shape): a possibly-given particle opening a name before a suffix comma folds into the family unreported. Under the pack,
Ten Smith, Jr.→ familyTen Smith; by default on master,Van Smith, Jr.reads the same. Recorded under the decisions entry's Left out.Docs and rules amended
tenandoudebe particles? (Jan ten Brinkgives middleten, familyBrink) #1455 Log entry carrying every recipe above.Oudeexample.available().fix/feat(#1455),paritywhere the fields match the 1.4.0 wheel;parity_check.pyreports 0 of 628 rows reading otherwise), plus the recorded sweep counts in tests/v2/test_cases.py, moved with a dated note.particles-aside, asJan van Berg/Jan Bergalready is.Checks
uv run pytest(50,068 passed after the review fixes) anduv run pytest -n0 -m serial, on 3.11. Neither environment has thejaextra installed.jaextra, in its own environment: test_locales, test_cldr_agreement and test_rules_doc.uv run mypy,uv run ruff check,uv run python tools/vocab/build.py --check.uv run sphinx-build -b doctest docs <tmp>, and the html build: clean.-n0.Review aspects run
All run on the two implementation commits; every finding was fixed in
10cb9859, which was then reviewed again.John Smith, VDcost, a lower-case claim fortenresting on one source of three, and a P2 count its cited entry did not hold.Oude.Oudeis not always followed by another word (De Oude); migrate.rst's 3.1 scope; languages.rst overstating which Dutch particles the default reads; wording.-particles-asideverdict that moves True → False forPiet Oude Luttikhuis/Piet Luttikhuis, asvanalready does.ar.py.🤖 Generated with Claude Code