Adjust tail command to use configurable keep_releases#4177
Open
andreapozza wants to merge 2 commits intodeployphp:masterfrom
Open
Adjust tail command to use configurable keep_releases#4177andreapozza wants to merge 2 commits intodeployphp:masterfrom
andreapozza wants to merge 2 commits intodeployphp:masterfrom
Conversation
antonmedv
requested changes
Mar 6, 2026
| return []; | ||
| } | ||
|
|
||
| $keep_releases = get('releases_log_limit', get('keep_releases', 300)); |
Member
There was a problem hiding this comment.
I don’t think fallback to keep_releases is appropriate.
Also, we should define it as other variables. with description and comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the release log handling in the deployment script to make the number of release log entries retained configurable, improving flexibility for different deployment environments.
Release log configuration:
recipe/deploy/release.php: Introduced the$keep_releasesvariable, which uses the value fromreleases_log_limitor falls back tokeep_releases(defaulting to 300), to determine how many release log entries to keep when reading.dep/releases_log. This replaces the previously hardcoded value of 300.