Repository navigation
feat(web): refresh the dashboard's visual design - #99
Merged
Merged
Conversation
Introduces a shared color-token system (assets/css/tokens.css, mapped to Tailwind utilities in app.css's @theme block) so every page's chrome - backgrounds, borders, text, buttons - reads from one place instead of scattered light/dark class pairs. Replaces every page's old banner-plus-form header with a compact Toolbar row: the selection chips (where a page has them), a Settings popover for less-used config fields, and the primary action pushed to the right. The chip selectors (MultiSelect, MultiSelectList) now toggle open/closed instantly client-side instead of round-tripping to the server, and close on click-away or Escape. Converts the Apps, Processes, Network, ETS, and Crashdump pages' inline, scroll-to-find detail panels into a shared bottom-docked panel that slides up on open, with collapse/expand/close controls and padding so it never overlaps the page's own content. Adds a live countdown timer (and, on the Tracing page, a running message count) next to RUN/STOP while a trace or profiling session is active, ticking down client-side via a small Countdown JS hook.
thiagoesteves
commented
Nov 12, 2026
thiagoesteves
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review notes from a pass over this diff.
- Reset the bottom-docked panel's collapsed/expanded state on both selecting
a new row and closing the panel, so opening a different row's details never
inherits a stale collapsed state (ets, crashdump, network, processes, apps).
- Gate the multi-select dropdown's unselected items behind :if={@show_options}
again, so the full list isn't shipped to the client until the dropdown is
actually opened; restores the metrics test that was guarding this.
- Truncate the trace/profiling session's expiry timestamp to millisecond
precision before encoding it, so the countdown hook's `new Date()` parse
stays within the ECMA-262 guaranteed format instead of risking "NaNs".
- Extract the duplicated bottom-panel chrome into Observer.Web.Components.DetailsPanel,
the duplicated Settings popover into Observer.Web.Components.SettingsPanel,
the repeated CTA/badge class strings into Core.action_button_class/0 and
Core.badge_class/1, and the repeated session-expiry computation into
Helpers.trace_expires_at/1.
- Migrate two leftover un-tokenized text colors in process_actions.ex and
port_actions.ex to text-base-content.
Collaborator
Author
|
Thanks for the thorough pass - all nine points addressed in 3cdd20b:
Full suite (484 tests), |
4 tasks done
thiagoesteves
added a commit
that referenced
this pull request
Nov 13, 2026
Risk assessment - Impact: version bump and CHANGELOG only; the release ships the access-control security fix (#77), several bug fixes, dark/light live metrics charts, the dashboard visual redesign, and Processes/Network search. - Blast radius: mix.exs version, CHANGELOG.md. - Regression risk: low for this commit; the shipped changes were reviewed and merged individually (#77, #88, #89, #90, #91, #99, #100). - Rollback: revert this commit. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assets/css/tokens.css, mapped to Tailwind utilities inapp.css's@themeblock) so every page's chrome reads from one place instead of scattered light/dark class pairs - documented in the README under a new "Theming" section.Toolbarrow: selection chips where a page has them, aSettingspopover for less-used config fields, and the primary action pushed to the right.MultiSelect/MultiSelectListnow toggle open/closed instantly client-side instead of round-tripping to the server, and close on click-away or Escape.CountdownJS hook.Test plan
mix test),mix format --check-formatted, andmix credo --strictall pass locally pre-rebase./observer/{applications,system,crashdump,ets,logs,metrics,network,processes,profiling,tracing}) manually verified in the browser against a live multi-node dev setup through the course of this change.mix deps.getwasn't re-run locally to avoid disrupting a live dev session; CI will validate the full build against the current lockfile).