Repository navigation
fix(ci): remove setup job to stop test/analysis blocking on unrelated matrix legs - #98
Merged
Merged
Conversation
… matrix legs needs: setup made every test leg (and the single analysis job) wait for all setup matrix legs to finish, not just the matching one, needlessly lengthening the critical path when one leg is slow. Folding setup's steps directly into test and analysis removes the cross-job dependency and the duplicate checkout/cache/install work it required. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
thiagoesteves
force-pushed
the
fix/ci-matrix-needs-blocking
branch
from
November 11, 2026 12:39
8abbb94 to
c0df96d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testandanalysisboth depended onneeds: setup, a matrix job. GitHub Actions resolvesneedsat the job level, so everytestleg (and the singleanalysisjob) had to wait for allsetupmatrix legs to finish, not just the matching one - needlessly lengthening the critical path if any one leg is slow.setupjob and folds its steps (seed static dir, npm install,mix deps.get, asset build, compile) directly intotestandanalysis. Each job is now fully independent with no cross-job dependency, and all legs/jobs start in parallel.mix compile --warnings-as-errorscheck, which previously only ran insidesetup, by adding it explicitly totest.Test plan
testx2,analysis) passtestandanalysisjobs start without waiting on each other in the Actions run graph