Skip to content

fix(ci): remove setup job to stop test/analysis blocking on unrelated matrix legs - #98

Merged
thiagoesteves merged 1 commit into
mainfrom
fix/ci-matrix-needs-blocking
Nov 11, 2026
Merged

thiagoesteves merged 1 commit into
mainfrom
fix/ci-matrix-needs-blocking

Conversation

@thiagoesteves

@thiagoesteves thiagoesteves commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • test and analysis both depended on needs: setup, a matrix job. GitHub Actions resolves needs at the job level, so every test leg (and the single analysis job) had to wait for all setup matrix legs to finish, not just the matching one - needlessly lengthening the critical path if any one leg is slow.
  • Removes the setup job and folds its steps (seed static dir, npm install, mix deps.get, asset build, compile) directly into test and analysis. Each job is now fully independent with no cross-job dependency, and all legs/jobs start in parallel.
  • Preserves the mix compile --warnings-as-errors check, which previously only ran inside setup, by adding it explicitly to test.
  • Net effect: fewer total job invocations than before (3 self-contained jobs vs. 2 setup legs + 2 test legs + 1 analysis job), and no artificial blocking between unrelated matrix legs.

Test plan

  • CI runs on this PR and all three jobs (test x2, analysis) pass
  • Confirm test and analysis jobs start without waiting on each other in the Actions run graph

… matrix legs

needs: setup made every test leg (and the single analysis job) wait for
all setup matrix legs to finish, not just the matching one, needlessly
lengthening the critical path when one leg is slow. Folding setup's
steps directly into test and analysis removes the cross-job dependency
and the duplicate checkout/cache/install work it required.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@thiagoesteves
thiagoesteves force-pushed the fix/ci-matrix-needs-blocking branch from 8abbb94 to c0df96d Compare November 11, 2026 12:39
@thiagoesteves
thiagoesteves merged commit d8079d9 into main Nov 11, 2026
3 checks passed
@thiagoesteves
thiagoesteves deleted the fix/ci-matrix-needs-blocking branch November 11, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant