Repository navigation
fix(test): raise wait_until timeout in tracing page tests - #107
Merged
Merged
Conversation
…I flakiness The real tracing pipeline (dbg to Tracer.Server to PubSub to LiveView) is async, and the 2s polling deadline is occasionally too tight under loaded CI runners, causing intermittent timeouts unrelated to any actual regression. Several unrelated dependabot PRs failed on this same test today when their CI jobs ran concurrently. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both CI jobs on #103 (and two other unrelated dependabot PRs today) failed on the same test,
Observer.Web.Tracing.PageLiveTest, not on anything related to those PRs' dependency bumps.Root cause
The test exercises the real tracing pipeline (
dbg->Tracer.Server->PubSub->LiveView), which is asynchronous, and polls for the result with a 2 second deadline (wait_until/2). Under CI-runner contention (several dependabot PRs ran concurrently today), that window was occasionally too tight, producing an intermittent timeout unrelated to any real regression.Fix
Raise the default
wait_until/2timeout from 2s to 5s intest/observer_web/web/live/tracing/page_test.exs.Test plan
mix test test/observer_web/web/live/tracing/page_test.exs- 12 tests, 0 failures (3 repeated runs)mix test- full suite, 486/486 passingmix format --check-formatted🤖 Generated with Claude Code