feat: allow downloader TLS configuration via Java system properties - #8825
Open
chadlwilson wants to merge 2 commits into
Open
chadlwilson wants to merge 2 commits into
chadlwilson wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A missing semicolon prevents Downloader.java from compiling.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates Downloader so pooled HTTP connections honor Java TLS system properties, including mTLS configuration.
Changes:
- Enables system properties on the pooled connection manager.
- Shares the configured manager with HTTP clients.
- Compilation is blocked by a missing semicolon after
build().
| File | Description |
|---|---|
utils/src/main/java/org/owasp/dependencycheck/utils/Downloader.java |
Configures pooled connections from Java system properties. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Extends use of standard Java system properties to the TLs configuration behind pooled connections, not solely proxy or http client-level settings settings, etc.
Related issues
Have test cases been added to cover the new functionality?
no - standard Apache Client functionality.