Skip to content

Generate proxy image attestations - #241

Open
JamieMagee wants to merge 3 commits into
mainfrom
generate-proxy-image-attestations
Open

Generate proxy image attestations#241
JamieMagee wants to merge 3 commits into
mainfrom
generate-proxy-image-attestations

Conversation

@JamieMagee

@JamieMagee JamieMagee commented Sep 11, 2026

Copy link
Copy Markdown
Member

What are you trying to accomplish?

Publish GitHub build provenance for proxy images so consumers can verify their source. Push by digest, store attestations in GitHub and GHCR, then publish the image and Git tags.

Anything you want to highlight for special attention from reviewers?

Attestation failure stops tag publication. This replaces the shell publisher with pinned Docker actions and actions/attest. Local build/test behavior, platform support and tag formats stay unchanged.

How will you know you've accomplished your goal?

YAML lint and shell checks passed. A local registry exercise preserved the image digest under both release tags. Live OIDC issuance still needs an authorized main-branch run. The complete test suite was not run.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

Copilot AI balanced review requested due to automatic review settings September 11, 2026 06:34
@JamieMagee
JamieMagee requested a review from a team as a code owner September 11, 2026 06:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Production OIDC issuance and registry attestation still require validation through an authorized main-branch run.

Review tier: Balanced
Findings: None

What changed in this PR

Adds verifiable build provenance to GHCR image publication.

Changes:

  • Publishes images by digest and attests them before tagging.
  • Replaces the shell publisher with pinned actions.
  • Documents verification and tests workflow invariants.
File Description
.github/​workflows/​ghcr.yml Implements digest-based build, attestation, and tagging.
ghcr_workflow_test.go Tests publication ordering and security constraints.
README.md Documents provenance verification.
script/​cibuild-publish-ghcr Removes the superseded publisher.
script/​_common Removes the unused branch constant.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants