Generate proxy image attestations - #241
Open
JamieMagee wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Production OIDC issuance and registry attestation still require validation through an authorized main-branch run.
Review tier: Balanced
Findings: None
What changed in this PR
Adds verifiable build provenance to GHCR image publication.
Changes:
- Publishes images by digest and attests them before tagging.
- Replaces the shell publisher with pinned actions.
- Documents verification and tests workflow invariants.
| File | Description |
|---|---|
.github/workflows/ghcr.yml |
Implements digest-based build, attestation, and tagging. |
ghcr_workflow_test.go |
Tests publication ordering and security constraints. |
README.md |
Documents provenance verification. |
script/cibuild-publish-ghcr |
Removes the superseded publisher. |
script/_common |
Removes the unused branch constant. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Publish GitHub build provenance for proxy images so consumers can verify their source. Push by digest, store attestations in GitHub and GHCR, then publish the image and Git tags.
Anything you want to highlight for special attention from reviewers?
Attestation failure stops tag publication. This replaces the shell publisher with pinned Docker actions and
actions/attest. Local build/test behavior, platform support and tag formats stay unchanged.How will you know you've accomplished your goal?
YAML lint and shell checks passed. A local registry exercise preserved the image digest under both release tags. Live OIDC issuance still needs an authorized main-branch run. The complete test suite was not run.
Checklist