Progress still depends on variable tj#13
Open
Apfelholz wants to merge 1 commit intodennisklein:mainfrom
Open
Conversation
dennisklein
requested changes
Nov 8, 2024
Owner
dennisklein
left a comment
dennisklein
left a comment
There was a problem hiding this comment.
Pls rebase your commit onto main
Apfelholz
force-pushed
the
progress-still-depends-on-variable-tj
branch
from
6163c02 to
01930e1
Compare
dennisklein
requested changes
Nov 8, 2024
Owner
dennisklein
left a comment
dennisklein
left a comment
There was a problem hiding this comment.
Looks good now content-wise, please fix the formatting and rebase onto the main branch of this repo.
Apfelholz
force-pushed
the
progress-still-depends-on-variable-tj
branch
2 times, most recently
from
7a3b7cc to
2a657fa
Compare
dennisklein
requested changes
Nov 8, 2024
Apfelholz
force-pushed
the
progress-still-depends-on-variable-tj
branch
2 times, most recently
from
0023ce1 to
eafdc31
Compare
Apfelholz
commented
Nov 8, 2024
ptop.py
Outdated
| print(f"Error reading the file '{args.logfile}': {e}") | ||
| except ZeroDivisionError: | ||
| print("Error: Total jobs parameter must be a positive integer.") | ||
| print("Error: Total jobs parameter must be a positive integer.") No newline at end of file |
Collaborator
Author
There was a problem hiding this comment.
dont now way taht is thare, it schoden't be
Owner
There was a problem hiding this comment.
Check https://github.com/dennisklein/exercise_gnu_parallel_top/actions/runs/11742381109/job/32712985482?pr=13#step:6:18 -> "\ No newline at end of file"
Apfelholz
force-pushed
the
progress-still-depends-on-variable-tj
branch
from
eafdc31 to
9d54dd4
Compare
Apfelholz
force-pushed
the
progress-still-depends-on-variable-tj
branch
from
9d54dd4 to
a87bb0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #12