Template CSR4MPI for multi-scalar type support without recompilation - #4
Merged
Merged
Conversation
- Template all classes to support float, double, complex<float>, complex<double> - Remove CSR4MPI_VALUE_TYPE macro dependency from headers - Convert all implementations to header-only templates - Add type traits and type aliases for all scalar types - Add comprehensive tests for all 4 scalar types - Update tests and benchmarks to use templated classes Co-authored-by: deltaeecs <48714525+deltaeecs@users.noreply.github.com>
…plify ApproxEqual - Move GetMPIDatatype helper to Global.h to avoid code duplication - Simplify ApproxEqual in tests by removing unnecessary if-else branches - Use mpi_helper namespace for the consolidated helper function Co-authored-by: deltaeecs <48714525+deltaeecs@users.noreply.github.com>
Co-authored-by: deltaeecs <48714525+deltaeecs@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for multiple data types in library
Template CSR4MPI for multi-scalar type support without recompilation
Dec 4, 2025
deltaeecs
marked this pull request as ready for review
December 4, 2025 06:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates the
CSR4MPI_VALUE_TYPEcompile-time switch by converting all classes to C++ templates. All four scalar types (float, double, complex, complex) are now available simultaneously in a single library build.Changes
Templated classes (now header-only):
cCSRMatrix<Scalar>,cCommPattern<Scalar>,cRemoteEntry<Scalar>cCSRComm<Scalar>,cMumpsAdapter<Scalar>Templated operations:
SpMV<Scalar>(),SpMM<Scalar>(),SpMMBlas<Scalar>()LoadMatrixMarket<Scalar>(),DistributedSpMV<Scalar>()Type support in Global.h:
is_complex_v<T>,is_supported_scalar_v<T>,real_type_t<T>mpi_helper::GetMPIDatatype<Scalar>()Convenience aliases:
cCSRMatrixF,cCSRMatrixD,cCSRMatrixCF,cCSRMatrixCDUsage
Tests
Added
test_all_scalar_types.cppwith typed tests covering all 4 scalar types (52 tests total).Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.