fix(SourceGenerator): resolve hint name collision and improve DX for new registrations #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new registrations
- Include namespace in UniqueId to prevent collision when same-named
plugins exist in different namespaces
- Remove HandlerMethodValidator that blocked generation when handler
method was missing - types are now always generated so developers
can reference PreImage/PostImage when creating new handler methods
- Remove unused HasValidationError property from PluginStepMetadata
- Add GeneratedSourceInfo to test helper for hint name verification
Fixes chicken-and-egg problem where developers couldn't create handler
methods with correct signatures because the generated types didn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes chicken-and-egg problem where developers couldn't create handler
methods with correct signatures because the generated types didn't exist.