fix(webhook): subscribe to inline review comments - #714
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe GitHub webhook registration now subscribes to ChangesGitHub webhook event registration
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to No concrete current-head risk remains for this webhook registration change. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #713
Motivation
Standing watches already match mentions in
comment.body, including inline PR review comments, but the GitHub hook registration command omittedpull_request_review_comment. The initial review could arrive throughpull_request_review; edits and replies to inline comments never reached the receiver.Changes
pull_request_review_commentin the ready-madegh apihook registration commandValidation
nix build -L --keep-going .#checks.aarch64-linux.module-generated-up-to-date .#checks.aarch64-linux.assemble-module-escaping .#checks.aarch64-linux.backend-parity .#checks.aarch64-linux.one-spec-both-backends .#checks.aarch64-linux.golden-snapshotpython3 tests/test_agentbox.py(151 tests, 1 skipped)nix build -L --keep-going .#packages.aarch64-linux.ci-nativeReview
created/edited+comment.bodywatch predicate handles its payload shape.defangdevs/local-channelshook and confirmed its returned event list containspull_request_review_comment; thedefangdevs/agent-boxhook already contained it.User-visible effect
Newly registered hooks receive inline PR review-comment creation, edit, and reply events. Existing hooks must add that GitHub event once; the live hooks for this box are already updated.