fix: close file descriptor in deepspeed_io_handle_t::wait() to prevent fd leak#8075
Open
MarkCLChang wants to merge 1 commit into
Open
fix: close file descriptor in deepspeed_io_handle_t::wait() to prevent fd leak#8075MarkCLChang wants to merge 1 commit into
MarkCLChang wants to merge 1 commit into
Conversation
…t fd leak Signed-off-by: markcl_chang <markcl_chang@adata.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses a file descriptor leak in
deepspeed_io_handle_t::wait()by ensuring the file descriptor is properly closed after the async I/O operation completes.Changes
close()call on the file descriptor at the end ofdeepspeed_io_handle_t::wait()to prevent fd accumulation during repeated async I/O operations.