Fix incorrect variable name #8051
Open
Muneerali199 wants to merge 1 commit into
Open
Conversation
….values() - Line 2968: wrap .values() with list() since dict_values is not subscriptable - Line 2972: self.ev_values -> ev_values (local variable, not instance attr) Fixes deepspeedai#7983
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7983
Two bugs in the eigenvalue monitoring logging code:
Non-subscriptable
dict_values:self.block_eigenvalue.values()returns adict_valuesview object which does not support indexing. Wrapped withlist()to make it subscriptable.Wrong variable name:
self.ev_valueswas used instead of the local variableev_values.self.ev_valuesis never defined anywhere in the class, causingAttributeErrorwhen this code path is hit.