Open
Conversation
The CMake interface file names vary between recent versions of flatbuffers. This patch handles both cases, for initial build and projects using the system-wide installation.
Add /usr/include/sigmf to the include file search path, so that applications following the README.md Usage will work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patches used in my initial Debian packaging for system-wide use of libsigmf.
The reliable finding patch handles variations in CMake interface file naming in recent
flatbuffers. 2.0.8, 22.12.06. This is needed to find the FlatBuffersConfig.cmake in Debian's
flatbuffers 2.0.8+dfsg1-2.
The fix cmake interface patch is needed so that another application can just
#include <sigmf.h>
as suggested in the README.md, even though the system-wide config location is
/usr/include/sigmf/sigmf.h
For your consideration, so that a libsigmf 1.0.3 release might work as expected system-wide.