Skip to content

refactor: centralizing shared compaction utils - #12311

Merged
sjrl merged 2 commits into
mainfrom
refactor/compaction-shared-utils
Aug 12, 2026
Merged

refactor: centralizing shared compaction utils#12311
sjrl merged 2 commits into
mainfrom
refactor/compaction-shared-utils

Conversation

@sjrl

@sjrl sjrl commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Related Issues

Proposed Changes:

Moving over util functions to the shared utils file that will eventually be used by the summarization compactor. Doing this now to reduce the size of the PR that will introduce the summarization compactor.

How did you test it?

Moved existing tests over and added new ones

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@sjrl sjrl self-assigned this Aug 11, 2026
@vercel

vercel Bot commented Aug 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Preview Aug 12, 2026 6:57am

Request Review

@sjrl sjrl added ignore-for-release-notes PRs with this flag won't be included in the release notes. and removed topic:tests labels Aug 11, 2026
@github-actions github-actions Bot added the type:documentation Improvements on the docs label Aug 11, 2026
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/hooks/compaction
  sliding_window.py
  utils.py
Project Total  

This report was generated by python-coverage-comment-action

@sjrl
sjrl marked this pull request as ready for review August 12, 2026 06:58
@sjrl
sjrl requested a review from a team as a code owner August 12, 2026 06:58
@sjrl
sjrl requested review from anakin87 and removed request for a team August 12, 2026 06:58

@anakin87 anakin87 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sjrl
sjrl merged commit a677234 into main Aug 12, 2026
27 checks passed
@sjrl
sjrl deleted the refactor/compaction-shared-utils branch August 12, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants