docs(linkcontentfetcher): add defence-in-depth SSRF mitigation recipe#11737
Open
camgrimsec wants to merge 1 commit into
Open
docs(linkcontentfetcher): add defence-in-depth SSRF mitigation recipe#11737camgrimsec wants to merge 1 commit into
camgrimsec wants to merge 1 commit into
Conversation
Expand the existing 'Security considerations' snippet into a three-layer recipe
aligned with SECURITY.md's stated operator-responsibility model for SSRF:
1. URL pre-validation with ipaddress (tightened: explicit localhost reject,
domain allowlist for hostname URLs, adds is_multicast / is_unspecified).
2. Transport-layer NoPrivateIPTransport(httpx.HTTPTransport) re-resolves
the hostname and rejects forbidden IPs (defeats DNS rebinding). Plugged
in via the existing client_kwargs param. follow_redirects=False note.
3. Network-layer egress: Kubernetes NetworkPolicy YAML denying RFC1918 /
loopback / link-local CIDRs (with kube-dns exception), plus an AWS /
Docker note covering 169.254.169.254.
No code change. Pure docs PR. The original short snippet is preserved as
section 1; the rest is additive.
Signed-off-by: Cameron G <cambamwham2@gmail.com>
|
@camgrimsec is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the existing 'Security considerations' snippet into a three-layer recipe aligned with SECURITY.md's stated operator-responsibility model for SSRF:
No code change. Pure docs PR. The original short snippet is preserved as section 1; the rest is additive.
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.