chore(deps): update definitelytyped#80
Conversation
📝 WalkthroughWalkthroughBumps dev-only TypeScript declaration versions in package.json: Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
renovate
Bot
force-pushed
the
renovate/definitelytyped
branch
from
e7995d7 to
b6fd35b
Compare
renovate
Bot
force-pushed
the
renovate/definitelytyped
branch
from
b6fd35b to
136521d
Compare
renovate
Bot
force-pushed
the
renovate/definitelytyped
branch
from
136521d to
c44d7c3
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
renovate
Bot
force-pushed
the
renovate/definitelytyped
branch
2 times, most recently
from
324357d to
b43aa9e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
src/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: CI
package.json
[error] 1-1: Command failed with exit code 1: npm ci --prefer-offline --no-audit
renovate
Bot
force-pushed
the
renovate/definitelytyped
branch
3 times, most recently
from
b71a11c to
2b76688
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
src/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (1)
package.json (1)
2276-2276: Clarify @types/temp vs runtime tmp package.Line 2276 references
@types/temp@^0.9.0, but the runtime dependency istmp@^0.2.4(line 2218). Verify these refer to the same package or clarify the intent.
renovate
Bot
force-pushed
the
renovate/definitelytyped
branch
6 times, most recently
from
3ba1ac3 to
68e1475
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (2)
package.json (2)
2590-2590: No active codebase usage detected for react-json-treeSearches found no imports or component usage in the codebase. If this package is only a transitive dependency or not actively used, the version bump poses no compatibility risk. Verify manually that this dependency serves a purpose and check the DefinitelyTyped changelog if direct usage exists.
2586-2586: @types/pdfkit mismatch: types v0.17.0 but pdfkit runtime is v0.13.0pdfkit is used in
src/webviews/extension-side/plotting/plotViewer.node.ts(lines 71–81). The types version (0.17.0) is ahead of the runtime (0.13.0)—types should be backward compatible, but verify the types work correctly with the runtime version and that the basic pdfkit constructor and SVGtoPDF integration have no issues.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (3)
package.json (3)
2625-2625: Remove orphaned @types/temp: runtime temp package not present.The runtime
temppackage is not listed in dependencies. Having@types/temp^0.9.0 without the runtime package suggests unused type definitions—either remove the type definition or confirm the package is a transitive dependency.Likely an incorrect or invalid review comment.
2614-2614: Remove orphaned @types/react-json-tree dependency.The base package
react-json-treeis not installed, and@types/react-json-treeis unused throughout the codebase. Delete this dead dependency from package.json.
2610-2610: No action needed. pdfkit is not used in the codebase—the version bump for @types/pdfkit has no impact.
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
package.json (1)
2621-2621: Version mismatch already flagged.Types at 0.0.33 vs runtime
stack-traceat 0.0.10 (line 2560) already noted in past reviews.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
🔇 Additional comments (1)
package.json (1)
2610-2610: No pdfkit usage detected in the codebase, making the type/runtime version mismatch a non-issue. If pdfkit is unused, consider removing the dependency and its types rather than fixing version alignment.Likely an incorrect or invalid review comment.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (3)
package.json (3)
2614-2614: Remove deprecated @types/react-json-tree.This package remains deprecated. The upstream library provides its own types, and there's no react-json-tree runtime dependency.
2621-2621: Version mismatch persists.@types/stack-trace at 0.0.33 but runtime stack-trace (line 2560) remains at 0.0.10.
2625-2625: Wrong types package.@types/temp is for the "temp" package, but this codebase uses "tmp" (line 2565). Use only @types/tmp (line 2626).
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
| "@types/node": "^22.15.1", | ||
| "@types/node-fetch": "^2.6.12", | ||
| "@types/pdfkit": "^0.11.0", | ||
| "@types/pdfkit": "^0.17.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify pdfkit runtime version and check if types should match
echo "=== Runtime pdfkit version ==="
rg '"pdfkit"' package.json -A1 -B1
echo ""
echo "=== Type definitions version ==="
rg '"@types/pdfkit"' package.json -A1 -B1Repository: deepnote/vscode-deepnote
Length of output: 346
Align @types/pdfkit with runtime pdfkit version.
@types/pdfkit (^0.17.0) is ahead of runtime pdfkit (^0.13.0) and may reference unavailable APIs.
🤖 Prompt for AI Agents
In package.json around line 2610, the devDependency "@types/pdfkit": "^0.17.0"
is newer than the runtime "pdfkit" (^0.13.0) and may reference APIs that don't
exist at runtime; change the @types/pdfkit version to match the runtime (pin it
to a 0.13.x range compatible with pdfkit ^0.13.0, e.g. "^0.13.0" or the exact
0.13 version available), then run your package manager to install updated deps
and run the test/build to confirm no type/runtime mismatches.
| "@types/react": "^16.4.14", | ||
| "@types/react-dom": "^16.0.8", | ||
| "@types/react-json-tree": "^0.6.8", | ||
| "@types/react-json-tree": "^0.13.0", |
There was a problem hiding this comment.
Previously flagged as deprecated—upstream provides own types.
Past review noted package-lock.json deprecation: "react-json-tree provides its own type definitions." Consider removing this devDependency.
🤖 Prompt for AI Agents
In package.json around line 2614, the devDependency "@types/react-json-tree" is
redundant because react-json-tree ships its own types; remove the
"@types/react-json-tree" entry from devDependencies, run npm install (or yarn
install) to update package-lock.json (or yarn.lock), and then run the TypeScript
build/typecheck to ensure no type errors; if any references remain, remove or
update them accordingly.
| "@types/sinon": "^10.0.15", | ||
| "@types/sinonjs__fake-timers": "^6.0.1", | ||
| "@types/stack-trace": "0.0.29", | ||
| "@types/stack-trace": "0.0.33", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify stack-trace runtime version
echo "=== Runtime stack-trace version ==="
rg '"stack-trace"' package.json -C2
echo ""
echo "=== Type definitions version ==="
rg '"@types/stack-trace"' package.json -C2Repository: deepnote/vscode-deepnote
Length of output: 511
@types/stack-trace (0.0.33) version ahead of runtime stack-trace (0.0.10).
Type definitions are for a newer version than what's installed at runtime, which may cause type errors if the APIs differ between these versions.
🤖 Prompt for AI Agents
In package.json around line 2621, the @types/stack-trace dependency is at 0.0.33
while the runtime stack-trace package is 0.0.10; update package.json so the
versions match (either set "@types/stack-trace" to "0.0.10" or upgrade the
runtime "stack-trace" to 0.0.33), then run your package manager install to
update lockfiles and re-run TypeScript type-checks (and tests) to ensure no API
mismatches remain.
| "@types/svg-to-pdfkit": "^0.1.0", | ||
| "@types/tcp-port-used": "^1.0.0", | ||
| "@types/temp": "^0.8.32", | ||
| "@types/temp": "^0.9.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search for temp vs tmp usage
echo "=== Searching for 'temp' imports ==="
rg "from ['\"]temp['\"]|require\(['\"]temp['\"]" --type ts --type js -C2
echo ""
echo "=== Searching for 'tmp' imports ==="
rg "from ['\"]tmp['\"]|require\(['\"]tmp['\"]" --type ts --type js -C2
echo ""
echo "=== Package.json dependencies ==="
rg '"temp"|"tmp"' package.json -C1Repository: deepnote/vscode-deepnote
Length of output: 1837
Remove unused @types/temp dependency.
Codebase imports only tmp package (found in 4 files), never temp. The @types/temp entry at line 2625 is unused; @types/tmp at line 2626 is the correct type definition to keep.
🤖 Prompt for AI Agents
In package.json around line 2625, the dependency entry "@types/temp": "^0.9.0"
is unused and should be removed; keep the correct "@types/tmp" entry. Edit
package.json to delete the "@types/temp" line and run npm/yarn install (or
update lockfile) to ensure the dependency is removed from lock files.
1 participant
This PR contains the following updates:
4.3.6→4.3.202.0.1→2.0.37.1.6→7.1.82.8.12→2.8.194.1.7→4.1.120.7.0→0.7.24.0.0→4.0.31.0.2→1.0.45.0.37→5.0.385.0.3→5.0.75.13.4→5.13.104.14.181→4.17.2118.19.31→18.19.13022.15.31→22.19.32.6.12→2.6.13^0.11.0→^0.17.00.4.0→0.4.316.9.14→16.9.25^0.6.8→^0.13.07.1.23→7.1.349.21.20→9.22.33.0.9→3.0.1310.0.15→10.0.200.0.29→0.0.332.0.1→2.0.40.1.0→0.1.31.0.1→1.0.4^0.8.32→^0.9.00.2.3→0.2.61.4.8→1.4.111.88.0→1.107.01.60.0→1.72.4Configuration
📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.