Skip to content

Fix: compiling error in exciton_plotter.cpp - #7827

Open
dyzheng wants to merge 1 commit into
deepmodeling:developfrom
dyzheng:fix/exciton-plotter-template
Open

Fix: compiling error in exciton_plotter.cpp#7827
dyzheng wants to merge 1 commit into
deepmodeling:developfrom
dyzheng:fix/exciton-plotter-template

Conversation

@dyzheng

@dyzheng dyzheng commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

adding 'template' keyword for dependent eval_wfc_bloch call exciton_plotter.cpp calls orb_eval_.eval_wfc_bloch() where orb_eval_ is a dependent type, requiring the 'template' keyword under C++11 parsing rules.

Reminder

  • I have read AGENTS.md and docs/developers_guide/agent_governance.md.
  • I have linked an issue or explained why this PR does not need one.
  • I have added adequate unit tests and/or case tests, or explained why not.
  • I have listed the exact verification commands run and their results.
  • I have described user-visible behavior changes, including INPUT parameter changes.
  • I have explained core-module impact for ESolver, HSolver, ElecState, Hamilt, Operator, Psi, or other source/ changes.
  • I have requested any needed governance exception below.

Linked Issue

Fix #

Unit Tests and/or Case Tests for my changes

  • Commands run:
  • Result summary:
  • Checks not run, with reason:

What's changed?

  • Example: brief summary of the user-visible or developer-facing change.

Governance Notes

  • INPUT/docs changes:
  • Core module impact:
  • Exceptions requested:

exciton_plotter.cpp calls orb_eval_.eval_wfc_bloch<T>() where orb_eval_ is a
dependent type, requiring the 'template' keyword under C++11 parsing rules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant