Functions to support GLM and ground network subsetting #55
Functions to support GLM and ground network subsetting #55deeplycloudy wants to merge 2 commits intomasterfrom
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 75.44% 74.95% -0.50%
==========================================
Files 15 15
Lines 2024 2052 +28
==========================================
+ Hits 1527 1538 +11
- Misses 497 514 +17 ☔ View full report in Codecov by Sentry. |
|
The time-height plot has been changed to plot group times, addressing #54. Since the event locations are noisy, I also switched the vertical projection plots to use points at the group centroid position, and added those points to the plan plot. The group centroids are not parallax corrected using the same approach as the events. Instead, the built-in parallax correction in the LCFA files is used directly. I suspect that would be an easy change using the coordinate transforms already in place. |
|
the implementation of this could also probably be re-used to resolve #52 |
| lon_handle = bk_plot.ax_lon.plot(glm.group_lon, vert_proj_point_alt, | ||
| transform=bk_plot.ax_lon.get_xaxis_transform(), **points_kwargs) | ||
| lat_handle = bk_plot.ax_lat.plot(vert_proj_point_alt, glm.group_lat, | ||
| transform=bk_plot.ax_lat.get_yaxis_transform(), **points_kwargs) | ||
| plan_handle = bk_plot.ax_plan.plot(glm.group_lon, glm.group_lat, **points_kwargs) |
There was a problem hiding this comment.
See test result below, should this maybe be a call to scatter instead of plot (as the default/"no points_kwargs specified" for scatter is probably more in line with what's expected?
3 participants
Addresses #50