fix: DH-21383: Convert map center to TypedDict#1285
Open
jnumainville wants to merge 1 commit intodeephaven:mainfrom
Open
fix: DH-21383: Convert map center to TypedDict#1285jnumainville wants to merge 1 commit intodeephaven:mainfrom
jnumainville wants to merge 1 commit intodeephaven:mainfrom
Conversation
jnumainville
requested review from
a team,
Copilot and
mattrunyon
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves type safety for map plotting functions by introducing a typed dictionary for map center coordinates. The change replaces generic dict[str, float] type hints with a more descriptive MapCenter TypedDict.
Changes:
- Introduced
MapCenterTypedDict to provide structured typing for map center coordinates - Updated type hints for the
centerparameter across five map plotting functions - Added TypedDict import from the typing module
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mattrunyon
approved these changes
Feb 2, 2026
Collaborator
mattrunyon
left a comment
mattrunyon
left a comment
There was a problem hiding this comment.
Looks like some tests are failing
Collaborator
Author
|
Tests have been fixed in #1283 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts map center to TypedDict