Redaction test: the fake MongoDB URL uses a .test host - #249
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub secret scanning flagged
test/redaction_differential_test.exs(commit 3fe0551) as a "MongoDB Atlas Database URI with credentials". The value is a fixture:mongodb+srv://u:FAKEmongo@c.mongodb.net/…, with useruand passwordFAKEmongo, and the host doesn't exist. No credential is exposed, so none needs rotating. The test only needs a URL whose user info holds a password, so the host now has a.testdomain (db.example.test), which cannot be real and does not match the Atlas pattern.Scanning the tests, lib, docs, livebooks and examples for other provider-shaped secrets found only AWS's documented example key id (
AKIAIOSFODNN7EXAMPLE) and ids spelled out withFAKE.test/redaction_differential_test.exs: 10 tests, 0 failures.