Repository navigation
Keep Matroska track and album titles apart - #122
Merged
Merged
Conversation
TITLE at target 30 is the track. TITLE at target 50 is the album. Setting one no longer replaces the other, and an album-only ARTIST is not replaced when the track artist is set.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
+ Coverage 92.97% 92.98% +0.01%
==========================================
Files 282 282
Lines 54202 54260 +58
Branches 4961 4970 +9
==========================================
+ Hits 50392 50454 +62
+ Misses 2260 2258 -2
+ Partials 1550 1548 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
A TITLE at target 50 still displays as Title until a track title or a segment title exists. Writing Title still goes to target 30, so it does not replace the album title.
A file-level TITLE below a collection still displays when the track has none. Album stays the title at level 50.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TitleandAlbumwere the same MatroskaTITLEwhenever the file's most specific file-level target was 50. Setting either one replaced the other.TITLEat target 30 is the track.TITLEat target 50 is the album or movie.Titlewrites only level 30. When the track has noTITLE, the display is the segment title, then the most specific file-levelTITLEbelow a collection (70). That includes a lone album or movie title at 50, and a part (40), movement (20), shot (10), or edition (60) title when nothing more specific is set. An empty trackTITLEstill blocks every broader title.Albumalways reads and writes level 50. A collectionTITLEat 70 is neither Title nor Album.Artistwrites at level 30. Reading still inherits an album artist when the track has none.Fixes #121
Tests
dotnet test tests/TagLibSharp2.Tests/TagLibSharp2.Tests.csproj -c Debug -f net8.0 -p:WarningsNotAsErrors=CA2027 --filter FullyQualifiedName~MatroskaPassed: 101, Failed: 0, Skipped: 0