Repository navigation
fix: Keep saves from dropping bytes they still claim - #119
Merged
Merged
Conversation
A Matroska position edit refreshes the nested CRC before the parent. Setting a tag value keeps its sort name and the other languages. A save with no filesystem uses the one the file was read with. A short WAV reload, and a sample buffer that cannot be allocated, fail without writing. A RIFF size of 0xFFFFFFFF is read through to the end of the stream. A stream past 2 GiB returns a failure instead of throwing.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 92.97% 93.01% +0.03%
==========================================
Files 282 283 +1
Lines 54202 54782 +580
Branches 4961 5028 +67
==========================================
+ Hits 50392 50953 +561
- Misses 2260 2280 +20
+ Partials 1550 1549 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the save and read holes found on
mainat851b03f.SeekPositionor cue update refreshes that element's CRC-32 before the parent CRC.SORT_WITH, default flag, and the other languages of that name.SaveToFile()with no filesystem writes through the filesystem the file was read with. The same fallback is on the Matroska, MP3, FLAC, MP4, Ogg Vorbis, Ogg Opus, DSF, DFF, AIFF, and WAV writers.datachunk bigger thanArray.MaxLengthreturns that same failure instead of throwing.0xFFFFFFFFis read through to the end of the stream.MediaFile.Read(Stream)returns a failure when the stream is too large to load, matchingRead(string).Test plan
SORT_WITHand a non-default languagedatachunk just overArray.MaxLengthreturns a failuredotnet format --verify-no-changes