Skip to content

[Feature]: Write new Matroska cover attachments #115

Open

Description

@decriptor

Problem Statement

The Matroska reader returns image attachments as pictures. Save copies an existing Attachments element through. Setting Pictures does not add, replace, or remove an attachment.

The Matroska cover art guidance names the default cover cover.jpg or cover.png: https://www.matroska.org/technical/cover_art/index.html

Proposed Solution

When the caller sets pictures, write them as attachments. The front cover file name is cover.jpg or cover.png, matching that guidance. An attachment the caller did not change keeps its original file name and bytes. Fonts and other non-image attachments stay in the file.

A save that does not touch pictures keeps the original Attachments bytes, which is what pull request #106 does today.

Implement from RFC 9559 and the cover art guidance. This issue stays open after #53 closes on the tag round-trip.

Alternatives Considered

Leaving pictures read-only. Callers can display a cover and cannot replace one.

Additional Context

An existing attachment named cover.png is preserved by the current save path. New attachments are the gap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions