fix(settings): add aria-label to icon-only edit/delete buttons on AI provider keys#4922
Merged
Merged
Conversation
…provider keys The edit and delete buttons on each AI provider key row render only an icon (Edit01 / Trash01) with no accessible name, so a screen reader announces them as unlabeled "button" controls in a list where every row looks identical.
pedrofrxncx
enabled auto-merge (squash)
July 21, 2026 13:14
decocms Bot
pushed a commit
that referenced
this pull request
Jul 21, 2026
PR: #4922 fix(settings): add aria-label to icon-only edit/delete buttons on AI provider keys Bump type: patch - decocms (apps/mesh/package.json): 4.82.15 -> 4.82.16 Deploy-Scope: web
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This follows the same accessibility hardening pattern as #4904, #4907, and #4915 (which added aria-labels to icon-only actions-menu, KPI-chart, and mic/send buttons). The Edit and Delete buttons on each AI provider key row (
apps/mesh/src/web/views/settings/ai-providers/provider-key-row.tsx) render only anEdit01/Trash01icon with noaria-label, notitle, and no wrappingTooltip— so a screen reader announces both as an unlabeled "button" in a list where every row's controls are visually identical, giving no way to distinguish edit from delete non-visually.Fix
Added
aria-label="Edit provider key"andaria-label="Delete provider key"to the two icon-onlyButtons. Pure additive attribute change — no logic, styling, or behavior touched.Verification
bun run fmt— cleancd apps/mesh && bunx tsc --noEmit— clean (exit 0)How to confirm
Open Org Settings → AI Providers, add a provider key, then inspect the Edit/Delete icon buttons in the accessibility tree (or with a screen reader) — each now announces its action instead of just "button".
Summary by cubic
Add aria-labels to the icon-only Edit and Delete buttons on AI provider key rows so screen readers announce the correct action. They now read "Edit provider key" and "Delete provider key" instead of an unlabeled "button".
Written for commit 17408fd. Summary will update on new commits.