fix(monitoring): label KPI charts for screen readers#4907
Merged
Conversation
The monitoring dashboard's KPI charts (Tool Calls, Latency, Errors, AI Usage) render as bare SVGs with no accessible name, so screen reader users get nothing meaningful when landing on them. Add a required ariaLabel to KPIChart and wire role="img" + aria-label through to the underlying ChartContainer div.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The KPI charts in the org monitoring dashboard (Tool Calls, Latency, Errors, and the AI Usage row) render as bare recharts SVGs with no accessible name — a screen reader user landing on one gets either silence or a jumble of raw SVG element announcements, with no indication of what metric the chart shows.
Adds a required
ariaLabelprop toKPIChartand forwards it to the underlyingChartContainerdiv asrole="img"+aria-label, then supplies a concrete label at each of the 8 call sites in the monitoring overview tab (e.g. "Tool calls over time", "Average latency over time", "AI errors over time").This directly improves accessibility of the monitoring widgets, the stated focus for this area, with no behavior change to the rendered chart itself — only an added ARIA label.
To verify: open a browser's accessibility tree / VoiceOver on the org monitoring page and confirm each chart card now announces a descriptive label instead of nothing.
Locally ran:
bun run fmt(clean) andcd apps/mesh && bunx tsc --noEmit(clean, confirms the now-requiredariaLabelprop is supplied everywhereKPIChartis used). Full CI validates lint and the rest of the suite.Summary by cubic
Adds accessible names to monitoring KPI charts so screen readers announce what each chart shows. No visual changes.
ariaLabelrequired onKPIChartand forwarded asrole="img"+aria-labelon the container.Written for commit b2862b7. Summary will update on new commits.