test(e2e): rely on precheck for DataExport availability#2499
Open
eofff wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the runtime skip from the
DataExportse2e suite that checked whether thestorage-volume-data-managermodule is enabled.The suite already has
PrecheckSVDMandPrecheckDataExportlabels, so the environment suitability should be handled by prechecks before the test starts.Why do we need it, and what problem does it solve?
The test duplicated module availability validation in
BeforeEachand silently skipped execution whenstorage-volume-data-managerwas disabled.Prechecks are enough for this condition, and keeping the skip in the test hides configuration issues from the precheck layer.
What is the expected result?
DataExportse2e tests are selected or rejected by the existing prechecks. The test code no longer performs an additional skip based on thestorage-volume-data-managermodule state.Checklist