Skip to content

fix(vd): skip terminating PVC when selecting volume migration target #2494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loktev-d wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −3
Open

fix(vd): skip terminating PVC when selecting volume migration target #2494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions images/virtualization-artifact/pkg/controller/vd/internal/migration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,18 +641,26 @@ func (h MigrationHandler) createTargetPersistentVolumeClaim(ctx context.Context,
if err != nil {
return nil, err
}
switch len(pvcs) {

var livePVCs []corev1.PersistentVolumeClaim
for _, pvc := range pvcs {
if pvc.DeletionTimestamp.IsZero() {
livePVCs = append(livePVCs, pvc)
}
}

switch len(livePVCs) {
case 1: // only source pvc exists
case 2:
for _, pvc := range pvcs {
for _, pvc := range livePVCs {
// If TargetPVC is empty, that means previous reconciliation failed and not updated TargetPVC in status.
// So, we should use pvc, that is not equal to SourcePVC.
if pvc.Name == targetPVCName || pvc.Name != sourcePVCName {
return &pvc, nil
}
}
default:
return nil, fmt.Errorf("unexpected number of pvcs: %d, please report a bug", len(pvcs))
return nil, fmt.Errorf("unexpected number of pvcs: %d, please report a bug", len(livePVCs))
}

pvc := &corev1.PersistentVolumeClaim{
Expand Down
Loading