feat(vmop): add superseded phase#2492
Open
danilrwx wants to merge 2 commits into
Open
Conversation
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
a62ae41 to
29ceb47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a dedicated terminal
Supersededphase forVirtualMachineOperationresources.Technical changes:
VMOPPhaseSupersededto the API enum and CRD schema.status.phase=Supersededwhile keepingconditions[Completed].reason=Superseded.Why do we need it, and what problem does it solve?
Previously, VMOPs interrupted by a newer operation were reported as
Completedwithconditions[Completed].reason=Superseded.This made superseded operations look like successfully completed operations unless clients inspected condition details.
A dedicated
Supersededphase makes the terminal state explicit for users, automation, metrics, and CLI output.What is the expected result?
status.phase: Supersededconditions[Completed].status: "True"conditions[Completed].reason: SupersededSupersededVMOPs and metrics expose theSupersededphase.Checklist
Changelog entries