[snapshot] restore --wait: name the PVCs it does not await - #442
Open
kneumoin wants to merge 1 commit into
Open
Conversation
--wait already finishes without polling a dormant WaitForFirstConsumer claim, but it only mentioned each one in a progress line and summed them up as a counter, so an operator could not tell which restored claims the command stopped tracking. Collect those claims during the existing classification pass and write one list, before the remaining claims are polled: namespace/name, the StorageClass that was actually resolved (the cluster default is reported by its own name, not as an empty field), and its volumeBindingMode. The list is part of the command result, so it goes to an injectable writer wired to cmd.OutOrStdout() and a failed write fails the restore instead of exiting successfully with incomplete output. The classification itself is unchanged: which claims are awaited still follows selected node, live consumer, and provisioning events. A wait timeout now names the claim, its last observed status.phase, and states that the restored objects were already applied and are not rolled back. Help no longer implies that every restored PVC is awaited until Bound. Signed-off-by: Neumoin, Konstantin <konstantin.neumoin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--wait already finishes without polling a dormant WaitForFirstConsumer claim, but it only mentioned each one in a progress line and summed them up as a counter, so an operator could not tell which restored claims the command stopped tracking.
Collect those claims during the existing classification pass and write one list, before the remaining claims are polled: namespace/name, the StorageClass that was actually resolved (the cluster default is reported by its own name, not as an empty field), and its volumeBindingMode. The list is part of the command result, so it goes to an injectable writer wired to cmd.OutOrStdout() and a failed write fails the restore instead of exiting successfully with incomplete output.
The classification itself is unchanged: which claims are awaited still follows selected node, live consumer, and provisioning events. A wait timeout now names the claim, its last observed status.phase, and states that the restored objects were already applied and are not rolled back. Help no longer implies that every restored PVC is awaited until Bound.