Conversation
…view Implements Phases A, B, and C of the unified /plan command: Phase A - Foundation: - Add gap-analysis skill with 6 focus areas (completeness, architecture, security, performance, consistency, dependencies) and check-layers reference - Add design-review skill with 6 anti-pattern rules (N+1, god functions, missing parallelism, error handling gaps, missing caching, poor decomposition) and anti-patterns reference with before/after examples - Add designer agent (opus model, mode-driven: gap-analysis + design-review) - Add design mode to synthesizer (deduplication, confidence boost, blocking/ should-address/informational categorization) - Add fetch-issues-batch operation to git agent for multi-issue planning Phase B - Plugin: - Create devflow-plan plugin with /plan and /plan-teams commands - 17-phase pipeline in 7 blocks: requirements discovery, gap analysis, scope approval, implementation design, design review, plan approval, output - Produces machine-readable design artifacts at .docs/design/ - Register in plugins.ts (after devflow-specify) and marketplace.json - Add designer agent + gap-analysis, design-review skills to devflow-ambient Phase C - Ambient integration: - Rewrite plan:orch with 8-phase pipeline including gap analysis lite (2 designers), synthesizer design mode, and inline design review in Phase 6 - Update router SKILL.md: add design-review to PLAN rows (GUIDED + ORCHESTRATED)
…nd deprecate /specify - Remove exploration/planning phases (2-6) from /implement and /implement-teams; both now start directly at implementation using plan document, issue, or task description - Add plan document input parsing to Phase 1 Setup: reads .docs/design/*.md, extracts frontmatter (execution-strategy, context-risk, issue) and body sections - Renumber remaining phases 1-10 with combined Report+Record Decisions as Phase 10 - Update architecture ASCII trees and phase cross-references throughout - Update docs-framework SKILL.md: add .docs/design/ directory and Designer persistence rule - Update CLAUDE.md: 18 plugins, 12 agents, 41 skills, add /plan to command roster, update /implement description to reflect streamlined pipeline - Update README.md: add /plan to commands table, update /implement description, update plugin/skill counts, mark /specify as deprecated - Add deprecation notice to /specify and /specify-teams pointing to /plan - Add designer.md to .gitignore for build-generated agent copies Co-Authored-By: Claude <noreply@anthropic.com>
- Synthesizer agent: add missing 'design' mode to Input section mode list - CLAUDE.md: update Agent Teams count from 5 to 6 (includes /plan) - CLAUDE.md: add designer to Opus analysis agents in Model Strategy - plan-teams.md: add missing multi-issue naming convention to Phase 15
Owner
Author
Code Review Summary: feat/108-unified-plan-commandReview findings from 9 specialized reviewers (security, architecture, consistency, regression, performance, testing, complexity, typescript, documentation). BLOCKING ISSUES (5 items, ≥80% confidence)1. Stale agents in devflow-implement (95% confidence)Files: The // src/cli/plugins.ts - Line 71
agents: ['git', 'coder', 'simplifier', 'scrutinizer', 'evaluator', 'tester', 'validator'],// plugins/devflow-implement/.claude-plugin/plugin.json - Lines 20-21
"agents": [
"git",
"coder",
"simplifier",
"scrutinizer",
"evaluator",
"tester",
"validator"
],Impact: Dead weight in install footprint, violates clean separation principle. 2. Missing worktree-support in devflow-plan (90% confidence)Files: Designer agent requires // src/cli/plugins.ts - Line 65
skills: ['agent-teams', 'gap-analysis', 'design-review', 'patterns', 'knowledge-persistence', 'worktree-support'],// plugins/devflow-plan/.claude-plugin/plugin.json
"skills": [
"agent-teams",
"gap-analysis",
"design-review",
"patterns",
"knowledge-persistence",
"worktree-support"
],Every other plugin using Git agent (implement, code-review, resolve, debug, self-review, ambient) declares it. 3. Stale description in devflow-implement (92% confidence)File: - "description": "Complete task implementation workflow - orchestrates exploration, planning, coding, validation, and PR creation",
+ "description": "Complete task implementation workflow - accepts plan documents, issues, or task descriptions",This matches the corrected description in 4. Description drift across sources (92% confidence)Files: Update all references to remove "exploration, planning" and align with the new implement responsibility. 5. Path traversal in /implement plan document handling (82% confidence)File: The command reads plan documents without validating the path. A user could pass Fix: Add explicit path validation before reading: **Plan Document Handling** (when $ARGUMENTS is a path ending in `.md`):
0. **Validate the path is relative and within project root** (reject absolute paths, `..`, symbolic links)
1. Verify the file exists under `.docs/design/` or project working directory
2. Verify frontmatter contains `type: design-artifact` and `version: 1`
3. Verify `execution-strategy` is one of: SINGLE_CODER, SEQUENTIAL_CODERS, PARALLEL_CODERS
4. Verify `context-risk` is one of: LOW, MEDIUM, HIGH, CRITICALSHOULD-FIX ISSUES (60-79% confidence)
RATE LIMIT & TECHNICAL NOTES
Recommendation: CHANGES_REQUESTED Fix the 5 blocking issues (manifests, path validation, descriptions) before merge. Should-fix items can be deferred to follow-up if time-critical. Generated by Claude Code review agent — /comment-pr operation |
added 5 commits
April 8, 2026 00:56
Addresses review issues 1,2,3,5,7,11-15,20 from code review. Removes devflow-specify plugin entirely, updates manifests, docs, tests, and launch materials.
Fold pruning comment into JSDoc block for consistency. Add devflow-plan hint and fix devflow-implement hint in init picker.
Remove 'specify' from COMMAND_REFS in skill-references test. Add /plan section to docs/commands.md and update /implement workflow to reflect removal of exploration/planning phases.
Consolidates three redundant phase boundaries in the /plan pipeline: - Phases 2+3 → Phase 2 "Orient + Load Knowledge" (Skimmer + knowledge read run concurrently in one phase instead of sequentially across two) - Phases 15+16+17 → Phase 14 "Output" (store, issue, report as one phase) - Blocks 5+6 → Block 5 "Design Review + Approval" (design review and Gate 2 share one block header) Gate table updated (Gate 1: 8→7, Gate 2: 14→13). All cross-references, architecture diagrams, and error handling updated across plan.md, plan-teams.md, README.md, and docs/commands.md. No functionality removed.
- file-organization.md: 39→41 skills, 11→12 agents, add designer to shared agents list - skills-architecture.md: add gap-analysis and design-review to Tier 2, add /plan to agent-teams Used By - agent-design.md: add Designer to Worker examples, mention designer in shared agents note - contributing.md: 39→41 skills, 11→12 agents - plugins.ts: add devflow-specify→devflow-plan to LEGACY_PLUGIN_NAMES for upgrade migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #108 — Track 4: Unified Plan Command
/plancommand with gap analysis and design review — identifies specification gaps, generates actionable design artifacts, and validates architecture before implementationdesigneragent (Opus-tier) for architecture evaluation and design document generationgap-analysis(specification completeness checking) anddesign-review(architecture anti-pattern detection)/implementnow accepts plan documents — can be invoked with a design artifact, GitHub issue, or task description/specifydeprecated — replaced by/planwhich covers specification + design in a unified flowplan:orchorchestration skill updated for ambient mode integration (PLAN intent → ORCHESTRATED depth)Key changes (26 files, +2129/-483)
devflow-planwithplan.md,plan-teams.md,designer.mdagent,plugin.jsonshared/agents/designer.md— Opus-tier architecture analysisgap-analysis/SKILL.md+ references,design-review/SKILL.md+ references/implement/specify/planplan:orchexpanded with full pipeline (Skimmer → Explore → Designer → Synthesizer → Plan → Designer)devflow-planregistered inplugins.ts, test updatedTest plan
npm run buildpasses — all 71 skills distributed across pluginsnpm testpasses — 611/611 testsnode dist/cli.js init --plugin=planinstalls the new plugin/plancommand loads and runs gap analysis + design review pipeline/implementaccepts a plan document path and proceeds with implementation/specifyshows deprecation notice pointing to/planplan:orchcorrectly