Skip to content

Run Playwright e2e tests in WASM CI - #295

Open
tameware wants to merge 1 commit into
dds-bridge:developfrom
tameware:e2e-in-ci
Open

Run Playwright e2e tests in WASM CI#295
tameware wants to merge 1 commit into
dds-bridge:developfrom
tameware:e2e-in-ci

Conversation

@tameware

@tameware tameware commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Clear the .bazelrc -e2e filter in ci_wasm.yml with empty --test_tag_filters= so Playwright (dds_mvp_e2e_test inside //web:web_system_tests) actually runs in CI.
  • Add //python:ci_wasm_e2e_test to guard that WASM CI keeps clearing the filter.
  • Note the CI override in specs/web-mvp.md, specs/build-system.md, and docs/wasm_build.md.

Fixes #256

Test plan

  • bazelisk test //python:ci_wasm_e2e_test
  • Confirm CI – WASM job runs dds_mvp_e2e_test (not filtered by -e2e)
  • Spot-check that unit/system targets in the same step still pass

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the WASM CI workflow to ensure Playwright-based web e2e tests are no longer filtered out by the default .bazelrc -e2e tag filter, and adds a Python guard test + documentation notes to keep that CI behavior from regressing.

Changes:

  • Update .github/workflows/ci_wasm.yml to pass --test_tag_filters= so //web:web_system_tests includes dds_mvp_e2e_test in WASM CI.
  • Add //python:ci_wasm_e2e_test to assert (a) .bazelrc still excludes e2e by default and (b) WASM CI explicitly clears that filter.
  • Document the CI override in specs/web-mvp.md, specs/build-system.md, and docs/wasm_build.md.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
specs/web-mvp.md Notes that WASM CI clears the default -e2e filter so the e2e test runs as part of web_system_tests.
specs/build-system.md Documents that the default -e2e filter exists and that WASM CI clears it for Playwright.
python/tests/ci_wasm_e2e_test.py Adds a guard test asserting .bazelrc excludes e2e by default and ci_wasm.yml clears the filter on its bazelisk test invocation.
python/BUILD.bazel Registers the new ci_wasm_e2e_test and wires required runfiles (.bazelrc, workflows).
docs/wasm_build.md Documents that WASM CI passes empty --test_tag_filters= so //web:web_system_tests includes Playwright.
.github/workflows/ci_wasm.yml Clears inherited -e2e filtering by adding --test_tag_filters= to the WASM CI test step.

@tameware tameware self-assigned this Aug 7, 2026
@tameware

tameware commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

Confirmed the e2e tests are running:

[342 / 344] 7 / 9 tests; Testing //web:dds_mvp_e2e_test; 3s local ... (2 actions running)
[342 / 344] 7 / 9 tests; Testing //web:dds_mvp_e2e_test; 5s local ... (2 actions running)
[343 / 344] 8 / 9 tests; Testing //web:dds_mvp_e2e_test; 7s local
[343 / 344] 8 / 9 tests; Testing //web:dds_mvp_e2e_test; 17s local
[343 / 344] 8 / 9 tests; Testing //web:dds_mvp_e2e_test; 38s local

@tameware
tameware requested a review from zzcgumn August 7, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run the e2e tests in our CI

2 participants