Run Playwright e2e tests in WASM CI - #295
Open
tameware wants to merge 1 commit into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WASM CI workflow to ensure Playwright-based web e2e tests are no longer filtered out by the default .bazelrc -e2e tag filter, and adds a Python guard test + documentation notes to keep that CI behavior from regressing.
Changes:
- Update
.github/workflows/ci_wasm.ymlto pass--test_tag_filters=so//web:web_system_testsincludesdds_mvp_e2e_testin WASM CI. - Add
//python:ci_wasm_e2e_testto assert (a).bazelrcstill excludese2eby default and (b) WASM CI explicitly clears that filter. - Document the CI override in
specs/web-mvp.md,specs/build-system.md, anddocs/wasm_build.md.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
specs/web-mvp.md |
Notes that WASM CI clears the default -e2e filter so the e2e test runs as part of web_system_tests. |
specs/build-system.md |
Documents that the default -e2e filter exists and that WASM CI clears it for Playwright. |
python/tests/ci_wasm_e2e_test.py |
Adds a guard test asserting .bazelrc excludes e2e by default and ci_wasm.yml clears the filter on its bazelisk test invocation. |
python/BUILD.bazel |
Registers the new ci_wasm_e2e_test and wires required runfiles (.bazelrc, workflows). |
docs/wasm_build.md |
Documents that WASM CI passes empty --test_tag_filters= so //web:web_system_tests includes Playwright. |
.github/workflows/ci_wasm.yml |
Clears inherited -e2e filtering by adding --test_tag_filters= to the WASM CI test step. |
Collaborator
Author
|
Confirmed the e2e tests are running: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.bazelrc-e2efilter inci_wasm.ymlwith empty--test_tag_filters=so Playwright (dds_mvp_e2e_testinside//web:web_system_tests) actually runs in CI.//python:ci_wasm_e2e_testto guard that WASM CI keeps clearing the filter.specs/web-mvp.md,specs/build-system.md, anddocs/wasm_build.md.Fixes #256
Test plan
bazelisk test //python:ci_wasm_e2e_testdds_mvp_e2e_test(not filtered by-e2e)Made with Cursor