Suppress gtest character-conversion warning for build, not only test#190
Open
tameware wants to merge 1 commit into
Open
Suppress gtest character-conversion warning for build, not only test#190tameware wants to merge 1 commit into
tameware wants to merge 1 commit into
Conversation
The -Wno-character-conversion / -Wno-conversion suppressions were scoped to the `test` command, so they only took effect under `bazel test`. Plain `bazel build` of test targets (and tooling that compiles GoogleTest) still emitted the gtest-printers.h warning. Move the flags to the `build` config, which is inherited by `test`, `run`, etc., so the warning is suppressed in both cases. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The -Wno-character-conversion / -Wno-conversion suppressions were scoped to the
testcommand, so they only took effect underbazel test. Plainbazel buildof test targets (and tooling that compiles GoogleTest) still emitted the gtest-printers.h warning. Move the flags to thebuildconfig, which is inherited bytest,run, etc., so the warning is suppressed in both cases.