chore: drop unused dev dependencies, unpin ty, refresh the lockfile - #827
Merged
axellpadilla merged 3 commits intoSep 2, 2026
Merged
Conversation
joshmarkovic
force-pushed
the
jm/refresh-dependencies
branch
2 times, most recently
from
August 28, 2026 14:34
76dd855 to
039bf93
Compare
joshmarkovic
force-pushed
the
jm/refresh-dependencies
branch
from
August 28, 2026 15:49
ff885cc to
039bf93
Compare
joshmarkovic
force-pushed
the
jm/refresh-dependencies
branch
2 times, most recently
from
August 28, 2026 17:06
e45ddf1 to
189917a
Compare
joshmarkovic
marked this pull request as ready for review
August 31, 2026 15:07
Nothing in the repo references any of them: - tox: no tox.ini, no setup.cfg, no [tool.tox] section - bumpversion: no config either; CONTRIBUTING documents bumping __version__.py by hand and the release workflow verifies it - pytest-csv: no --csv usage in pytest.ini, the Makefile or CI - pytz: no imports anywhere pytz stays installed as a transitive dependency of dbt-adapters and dbt-common, so nothing changes at runtime. Removing the direct declaration only drops a claim this repo does not use. Relocking drops seven packages and moves no versions: the four above, plus bump2version (reachable only via bumpversion) and cachetools, pyproject-api and tomli-w (reachable only via tox).
The exact `ty==0.0.64` constraint duplicated a version uv.lock already carries, and every caller reaches ty through `uv run --frozen`, so the lock is what they resolve either way. Two homes for one number, with nothing keeping them in step. Relocking records the loosened constraint and holds ty at 0.0.64, so this commit changes no versions. Drop the sentence above the pre-commit hook claiming ty's version comes from pyproject.toml, which this makes untrue. What remains is the part a reader still needs: why the hook passes no filenames.
`uv lock --upgrade`. A second run reports no further changes, so everything is at its current ceiling. ruff moves 0.15.13 to 0.16.5, so the ruff-pre-commit rev moves from v0.15.20 to v0.16.5 in the same commit. The two are set by different mechanisms and had already drifted; bumping the rev here keeps the hooks, `make ruff`, `make format` and a direct `uv run ruff` on one version. Landing the lock without the rev would leave the tree mismatched again. ty picks up 0.0.64 to 0.0.75, superseding dbt-msft#812.
axellpadilla
force-pushed
the
jm/refresh-dependencies
branch
from
September 2, 2026 01:10
189917a to
0934a19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development-dependency housekeeping in three atomic commits.
[project.dependencies]is untouched, so nothing changes for people installing the adapter.drop four unused development dependenciespyproject.toml+ lock. Removes 7 packages, moves no versionsunpin typyproject.toml+ lock + one stale comment. Changes no versionsrefresh the lockfile and match the ruff hook to itruff-pre-commitrev. All the version movementEach commit was checked out and verified on its own:
uv lock --checkconsistent,ruff checkandty checkclean, 500 unit tests passing at every one.1. Drop four unused dev dependencies
Nothing in the repo references any of them:
toxtox.ini, nosetup.cfg, no[tool.tox]sectionbumpversion__version__.pyby hand, andrelease-version.ymlverifies it against the tagpytest-csv--csvusage inpytest.ini, the Makefile or CIpytzpytzstays installed as a transitive dependency ofdbt-adaptersanddbt-common, so nothing changes at runtime. Removing the direct declaration only drops a claim this repo does not use.2. Unpin ty
ty==0.0.64duplicated a versionuv.lockalready carries, and every caller reaches ty throughuv run --frozen, so the lock is what they resolve either way. Two homes for one number, with nothing keeping them in step.Relocking records the loosened constraint and holds ty at 0.0.64, so this commit moves no versions. It also drops the sentence above the pre-commit hook claiming ty's version comes from
pyproject.toml, which the unpin makes untrue; what remains is the part a reader still needs, namely why the hook passes no filenames.3. Refresh the lockfile, and match the ruff hook to it
uv lock --upgrade. A second run reports no further changes, so everything is at its current ceiling.ruffmoves 0.15.13 to 0.16.5, so theruff-pre-commitrev moves fromv0.15.20tov0.16.5in the same commit. Those two numbers are set by different mechanisms and had already drifted; bumping the rev alongside the lock keeps the hooks,make ruff,make formatand a directuv run ruffon one version, and avoids landing a tree that is mismatched again. Verified: pre-commit's isolated environment anduv run ruffboth report 0.16.5.The two upgrades worth a closer look are
mssql-python1.7.1 to 1.14.0, a driver jump the unit tests cannot exercise, anddbt-core1.12.0 to 1.12.3.Supersedes
Five open PRs, each landing at or below what is resolved here:
cryptography48.0.0 to 50.0.0msgpack1.1.2 to 1.2.1pyjwt2.12.1 to 2.13.0ty==0.0.64toty==0.0.74ruff-pre-commitrev: v0.15.20tov0.16.4v0.16.5Not covered, still needs its own merge: #824, the github-actions group (
docker/login-action,astral-sh/setup-uv). Not a Python dependency.Upgraded (52)
annotated-typesasttokensbuildcertificfficharset-normalizerclickcoveragecryptographydbt-commondbt-coredbt-core-experimental-parserdbt-protosdistlibdocutilsfilelockidnaimportlib-metadataipythonjaraco-functoolsmashumarometricflowmsalmsgpackmssql-pythonnh3packagingplatformdirspre-commitprompt-toolkitpyarrowpydanticpydantic-corepygmentspyjwtpytestpython-discoverypython-dotenvpytzreadme-rendererrpds-pyruffsqlglotsqlparsetraitletstwinetytyping-extensionstyping-inspectiontzdatavirtualenvwcwidthAdded (2)
mssql-python-odbcmssql-pythonopentelemetry-apidbt-commonanddbt-coreRemoved (7)
bump2versionbumpversionbumpversioncachetoolstoxpyproject-apitoxpytest-csvtomli-wtoxtoxTesting
Green on the branch tip, and at each individual commit, rebased on current master:
pre-commit run -a: all hooks pass, with the newv0.16.5rev resolving and installing cleanlyruff checkandruff format --check: clean under 0.16.5, so no reformatting rides alongty check: clean on 0.0.75, including withunused-ignore-commentenabled, so none of the existing# ty: ignoresuppressions have gone stalemake ruff,make format,make ty: all resolve their hook ids and passuv lock --check: lockfile consistent withpyproject.tomlDraft until the integration matrix runs, in particular the
mssql-pythonrows.